From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Alexander Graf <agraf@suse.de>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 3/3] target-ppc: virtex-ml507 machine type should depend on CONFIG_XILINX
Date: Tue, 26 Aug 2014 16:12:44 +1000 [thread overview]
Message-ID: <CAEgOgz7X=---Fi6GAW6LyCVLzk6vBNP3XSSX8SYkXVyUqbOfdg@mail.gmail.com> (raw)
In-Reply-To: <1409027418-4453-4-git-send-email-david@gibson.dropbear.id.au>
On Tue, Aug 26, 2014 at 2:30 PM, David Gibson
<david@gibson.dropbear.id.au> wrote:
> The virtex-ml507 is a Xilinx CPU based system, and requires several sub
> devices which are only included with CONFIG_XILINX. Therefore, it should
> only be compiled if CONFIG_XILINX is set.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
> hw/ppc/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/Makefile.objs b/hw/ppc/Makefile.objs
> index edd44d0..19d9920 100644
> --- a/hw/ppc/Makefile.objs
> +++ b/hw/ppc/Makefile.objs
> @@ -20,4 +20,4 @@ obj-$(CONFIG_MAC) += mac_newworld.o
> obj-$(CONFIG_E500) += e500.o mpc8544ds.o e500plat.o
> obj-$(CONFIG_E500) += mpc8544_guts.o ppce500_spin.o
> # PowerPC 440 Xilinx ML507 reference board.
> -obj-y += virtex_ml507.o
> +obj-$(CONFIG_XILINX) += virtex_ml507.o
> --
> 1.9.3
>
>
next prev parent reply other threads:[~2014-08-26 6:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 4:30 [Qemu-devel] [0/3] target-ppc Fixes for some missing config dependencies David Gibson
2014-08-26 4:30 ` [Qemu-devel] [PATCH 1/3] target-ppc: Disable PReP testcases with !CONFIG_PREP David Gibson
2014-08-26 4:30 ` [Qemu-devel] [PATCH 2/3] target-ppc: Disable ppc Mac tests when !CONFIG_MAC David Gibson
2014-08-26 4:30 ` [Qemu-devel] [PATCH 3/3] target-ppc: virtex-ml507 machine type should depend on CONFIG_XILINX David Gibson
2014-08-26 6:12 ` Peter Crosthwaite [this message]
2014-09-08 11:10 ` Alexander Graf
2014-08-26 8:34 ` [Qemu-devel] [0/3] target-ppc Fixes for some missing config dependencies Paolo Bonzini
2014-08-27 8:22 ` David Gibson
2014-08-27 10:08 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEgOgz7X=---Fi6GAW6LyCVLzk6vBNP3XSSX8SYkXVyUqbOfdg@mail.gmail.com' \
--to=peter.crosthwaite@xilinx.com \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).