Re: [PATCH v2 07/38] target/hexagon: Include missing 'exec/target_long.h' header

[Brian Cain <brian.cain@oss.qualcomm.com>]

[-- Attachment #1: Type: text/plain, Size: 1831 bytes --]

On Fri, Mar 13, 2026 at 1:21 AM Philippe Mathieu-Daudé <philmd@linaro.org>
wrote:

> The "exec/target_long.h" header is indirectly included, pulled
> via "exec/cpu-defs.h". Include it explicitly otherwise we'd get
> when removing the latter:
>
>   ../target/hexagon/cpu.h:76:5: error: unknown type name ‘target_ulong’
>      76 |     target_ulong gpr[TOTAL_PER_THREAD_REGS];
>         |     ^~~~~~~~~~~~
>   ../target/hexagon/mmvec/mmvec.h:69:5: error: unknown type name
> ‘target_ulong’
>      69 |     target_ulong va[MAX_VEC_SIZE_BYTES];
>         |     ^~~~~~~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>

Reviewed-by: Brian Cain <brian.cain@oss.qualcomm.com>

 target/hexagon/cpu.h         | 2 ++
>  target/hexagon/mmvec/mmvec.h | 3 +++
>  2 files changed, 5 insertions(+)
>
> diff --git a/target/hexagon/cpu.h b/target/hexagon/cpu.h
> index 85afd592778..7a91399fe02 100644
> --- a/target/hexagon/cpu.h
> +++ b/target/hexagon/cpu.h
> @@ -23,9 +23,11 @@
>  #include "cpu-qom.h"
>  #include "exec/cpu-common.h"
>  #include "exec/cpu-defs.h"
> +#include "exec/target_long.h"
>  #include "hex_regs.h"
>  #include "mmvec/mmvec.h"
>  #include "hw/core/registerfields.h"
> +#include "qemu/bitmap.h"
>
>  #ifndef CONFIG_USER_ONLY
>  #error "Hexagon does not support system emulation"
> diff --git a/target/hexagon/mmvec/mmvec.h b/target/hexagon/mmvec/mmvec.h
> index 52d470709c0..4a4f6cc9805 100644
> --- a/target/hexagon/mmvec/mmvec.h
> +++ b/target/hexagon/mmvec/mmvec.h
> @@ -18,6 +18,9 @@
>  #ifndef HEXAGON_MMVEC_H
>  #define HEXAGON_MMVEC_H
>
> +#include "exec/target_long.h"
> +#include "qemu/bitmap.h"
> +
>  #define MAX_VEC_SIZE_LOGBYTES 7
>  #define MAX_VEC_SIZE_BYTES  (1 << MAX_VEC_SIZE_LOGBYTES)
>
> --
> 2.53.0
>
>
>

[-- Attachment #2: Type: text/html, Size: 2899 bytes --]