From: Peter Maydell <peter.maydell@linaro.org>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-options: Fix space at EOL
Date: Fri, 23 Nov 2012 08:58:33 +0000 [thread overview]
Message-ID: <CAFEAcA-+Ji_nCSnAj3p9LYCCZ-PHUMoGPVfqT9uL14E==pTGOg@mail.gmail.com> (raw)
In-Reply-To: <8000c1db5e735e027860a47bde50d64ea4a96893.1353660725.git.mprivozn@redhat.com>
On 23 November 2012 08:52, Michal Privoznik <mprivozn@redhat.com> wrote:
> There's no need to add a space at the end of line.
> Moreover, it can make problems in some projects that
> store the help output into a file (and run couple of
> tests based on that) and have space at EOL forbidden.
I have no problem with this patch but I would suggest that
these other projects have a broken workflow if they're
reliant on QEMU's help output to not have trailing spaces
like that :-)
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
(and cc'd qemu-trivial).
-- PMM
> ---
> qemu-options.hx | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 9bb29d3..8f6d0e3 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1331,7 +1331,7 @@ DEF("net", HAS_ARG, QEMU_OPTION_net,
> " connect the host TAP network interface to VLAN 'n'\n"
> #else
> "-net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,script=file][,downscript=dfile][,helper=helper][,sndbuf=nbytes][,vnet_hdr=on|off][,vhost=on|off][,vhostfd=h][,vhostforce=on|off]\n"
> - " connect the host TAP network interface to VLAN 'n' \n"
> + " connect the host TAP network interface to VLAN 'n'\n"
> " use network scripts 'file' (default=" DEFAULT_NETWORK_SCRIPT ")\n"
> " to configure it and 'dfile' (default=" DEFAULT_NETWORK_DOWN_SCRIPT ")\n"
> " to deconfigure it\n"
next prev parent reply other threads:[~2012-11-23 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 8:52 [Qemu-devel] [PATCH] qemu-options: Fix space at EOL Michal Privoznik
2012-11-23 8:58 ` Peter Maydell [this message]
2012-12-03 12:58 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-+Ji_nCSnAj3p9LYCCZ-PHUMoGPVfqT9uL14E==pTGOg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).