Re: [Qemu-devel] [PATCH 0/5] miscellaneous minor cocoa UI patches

[Peter Maydell <peter.maydell@linaro.org>]

On 24 December 2013 13:03, Andreas Färber <andreas.faerber@web.de> wrote:
> Am 23.12.2013 17:08, schrieb Peter Maydell:
>> On 8 December 2013 22:59, Peter Maydell <peter.maydell@linaro.org> wrote:
>>> This patchset is a collection of minor Cocoa UI patches:
>>>  * the 'pass command key through when mousegrabbed' patch I sent
>>>    earlier (included here for convenience since the others in
>>>    the series would otherwise trivially conflict)
>>>  * typo fixes
>>>  * support for loading *.qcow2 via the "pick a disk image" dialog
>>>  * fix for a bug that meant using the 'pick an image' dialog
>>>    might cause us to fail to find BIOS image files later
>>>
>>> Peter Maydell (5):
>>>   ui/cocoa: Pass command key through to guest when VM has mousegrab
>>>   ui/cocoa: Correct typos in comments and variable names
>>>   ui/cocoa: Send warning message to stderr, not stdout
>>>   ui/cocoa: Add ".qcow2" to extension list for image load dialog
>>>   ui/cocoa: Fix code for starting QEMU via image file load dialog
>>
>> Ping! Last call for review/testing; otherwise I'll put these into a pullreq
>> with the MAINTAINERS file update and send it out in a week or so.
>
> I'm not anywhere near my Mac for testing over the holidays, so if you've
> taken reasonable assurance that patches don't just work on the latest
> and greatest x86_64 APIs then please feel free to submit a PULL.

The only two new API calls in any of these patches are
CGContextSetRGBFillColor() and CGContextFillRect(), both of
which are documented as "10.0 and up", so I think we're good on
that score, though I don't have any way of doing an actual test on 10.3
or PPC.

thanks
-- PMM