From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvTGH-0001Uz-Qu for qemu-devel@nongnu.org; Tue, 24 Dec 2013 09:47:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvTGB-0003dP-88 for qemu-devel@nongnu.org; Tue, 24 Dec 2013 09:47:09 -0500 Received: from mail-pd0-f170.google.com ([209.85.192.170]:33705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvTGB-0003d5-2c for qemu-devel@nongnu.org; Tue, 24 Dec 2013 09:47:03 -0500 Received: by mail-pd0-f170.google.com with SMTP id g10so6411414pdj.29 for ; Tue, 24 Dec 2013 06:47:02 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <52B98606.2030807@web.de> References: <1386543546-31919-1-git-send-email-peter.maydell@linaro.org> <52B98606.2030807@web.de> From: Peter Maydell Date: Tue, 24 Dec 2013 14:46:42 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/5] miscellaneous minor cocoa UI patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: QEMU Developers , Patch Tracking On 24 December 2013 13:03, Andreas F=C3=A4rber wro= te: > Am 23.12.2013 17:08, schrieb Peter Maydell: >> On 8 December 2013 22:59, Peter Maydell wrote= : >>> This patchset is a collection of minor Cocoa UI patches: >>> * the 'pass command key through when mousegrabbed' patch I sent >>> earlier (included here for convenience since the others in >>> the series would otherwise trivially conflict) >>> * typo fixes >>> * support for loading *.qcow2 via the "pick a disk image" dialog >>> * fix for a bug that meant using the 'pick an image' dialog >>> might cause us to fail to find BIOS image files later >>> >>> Peter Maydell (5): >>> ui/cocoa: Pass command key through to guest when VM has mousegrab >>> ui/cocoa: Correct typos in comments and variable names >>> ui/cocoa: Send warning message to stderr, not stdout >>> ui/cocoa: Add ".qcow2" to extension list for image load dialog >>> ui/cocoa: Fix code for starting QEMU via image file load dialog >> >> Ping! Last call for review/testing; otherwise I'll put these into a pull= req >> with the MAINTAINERS file update and send it out in a week or so. > > I'm not anywhere near my Mac for testing over the holidays, so if you've > taken reasonable assurance that patches don't just work on the latest > and greatest x86_64 APIs then please feel free to submit a PULL. The only two new API calls in any of these patches are CGContextSetRGBFillColor() and CGContextFillRect(), both of which are documented as "10.0 and up", so I think we're good on that score, though I don't have any way of doing an actual test on 10.3 or PPC. thanks -- PMM