From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akzhV-00012t-C6 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 15:53:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akzhU-0000w7-38 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 15:53:17 -0400 Received: from mail-vk0-x235.google.com ([2607:f8b0:400c:c05::235]:34605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akzhT-0000w2-Nx for qemu-devel@nongnu.org; Tue, 29 Mar 2016 15:53:16 -0400 Received: by mail-vk0-x235.google.com with SMTP id e185so33484775vkb.1 for ; Tue, 29 Mar 2016 12:53:15 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1459245425-4374-1-git-send-email-leon.alrae@imgtec.com> References: <1459245425-4374-1-git-send-email-leon.alrae@imgtec.com> From: Peter Maydell Date: Tue, 29 Mar 2016 20:52:55 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/21] target-mips queue for 2.6 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leon Alrae Cc: QEMU Developers , Aurelien Jarno On 29 March 2016 at 10:56, Leon Alrae wrote: > Hi, > > Here's MIPS pull request which adds initial implementation of MIPS Cohere= nt > Processing System including Cluster Power Controller and Global Config > Registers allowing the guest to control the start of other Virtual > Processors after reset. Also, this pullreq adds Inter-Thread Communicatio= n > Unit and MAAR. > > Thanks, > Leon > > Cc: Peter Maydell > Cc: Aurelien Jarno > > The following changes since commit b68a80139e37e806f004237e55311ebc421514= 34: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into = staging (2016-03-24 16:24:02 +0000) > > are available in the git repository at: > > git://github.com/lalrae/qemu.git tags/mips-20160329 > > for you to fetch changes up to e9f517b73dab520de05b871359d2beedf8b04e53: > > target-mips: add MAAR, MAARI register (2016-03-28 19:27:09 +0100) > > ---------------------------------------------------------------- > MIPS patches 2016-03-29 > > Changes: > * add initial MIPS CPS support > * implement ITU block > * implement MAAR Hi. I'm afraid this doesn't compile: /home/petmay01/linaro/qemu-for-merges/hw/misc/mips_cmgcr.c: In function =E2=80=98mips_gcr_init=E2=80=99: /home/petmay01/linaro/qemu-for-merges/hw/misc/mips_cmgcr.c:107:31: error: =E2=80=98error_abort=E2=80=99 undeclared (first use in this function= ) &error_abort); ^ /home/petmay01/linaro/qemu-for-merges/hw/misc/mips_cmgcr.c:107:31: note: each undeclared identifier is reported only once for each function it appears in CC mips64-softmmu/hw/misc/mips_itu.o make[1]: *** [hw/misc/mips_cmgcr.o] Error 1 make[1]: *** Waiting for unfinished jobs.... CC mips64el-softmmu/hw/misc/mips_cmgcr.o /home/petmay01/linaro/qemu-for-merges/hw/misc/mips_cpc.c: In function =E2=80=98mips_cpc_realize=E2=80=99: /home/petmay01/linaro/qemu-for-merges/hw/misc/mips_cpc.c:119:9: error: implicit declaration of function =E2=80=98error_setg=E2=80=99 [-Werror=3Dimplicit-function-declaration] error_setg(errp, ^ /home/petmay01/linaro/qemu-for-merges/hw/misc/mips_cpc.c:119:9: error: nested extern declaration of =E2=80=98error_setg=E2=80=99 [-Werror=3Dnested= -externs] cc1: all warnings being treated as errors (and similar other errors). I think you've unfortunately collided with a patch in Paolo's recent pull request which changes how we handle qapi/error.h (it's no longer pulled in by osdep.h by default); see commit da34e65cb. thanks -- PMM