From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Sergio Andres Gomez Del Real <sergio.g.delreal@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"patches@linaro.org" <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator
Date: Mon, 8 Jan 2018 21:01:15 +0000 [thread overview]
Message-ID: <CAFEAcA-+qwxFWF_PX7vKgp+Cvd0seyiAdY6zRMkd7R2feeuYzw@mail.gmail.com> (raw)
In-Reply-To: <bb1c8d49-c800-fe4f-4a93-ca5274a830f9@amsat.org>
On 8 January 2018 at 17:16, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> On 01/08/2018 02:10 PM, Peter Maydell wrote:
>> In commit c97d6d2cdf97ed we accidentally added code to configure
>> that uses '==' for string equality testing. This is a bashism --
>> the portable way to write this is '='.
>>
>> This fixes the "Unexpected operator error" complaint produced
>> if the system /bin/sh is dash.
>
> Thanks :)
>
>>
>> Fixes: c97d6d2cdf97ed
>> Reported-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Applied to master, thanks.
-- PMM
prev parent reply other threads:[~2018-01-08 21:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 17:10 [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator Peter Maydell
2018-01-08 17:15 ` Eric Blake
2018-01-08 17:16 ` Philippe Mathieu-Daudé
2018-01-08 21:01 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-+qwxFWF_PX7vKgp+Cvd0seyiAdY6zRMkd7R2feeuYzw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=f4bug@amsat.org \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sergio.g.delreal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).