From: Peter Maydell <peter.maydell@linaro.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
QEMU Developers <qemu-devel@nongnu.org>,
Greg Kurz <groug@kaod.org>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
surajjs@au1.ibm.com, BALATON Zoltan <balaton@eik.bme.hu>
Subject: Re: [Qemu-devel] [PULL 06/11] hw/ide: Emulate SiI3112 SATA controller
Date: Thu, 18 Jan 2018 12:10:09 +0000 [thread overview]
Message-ID: <CAFEAcA--Gdhs+tTwGWw2S9PNuDOriaGCFKSAnLrEPciQGmL_=Q@mail.gmail.com> (raw)
In-Reply-To: <20180111045937.2119-7-david@gibson.dropbear.id.au>
On 11 January 2018 at 04:59, David Gibson <david@gibson.dropbear.id.au> wrote:
> From: BALATON Zoltan <balaton@eik.bme.hu>
>
> This is a common generic PCI SATA controller that is also used in PCs
> but more importantly guests running on the Sam460ex board prefer this
> card and have a driver for it (unlike for other SATA controllers
> already emulated).
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> Acked-by: John Snow <jsnow@redhat.com>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> + case 0x1c8:
> + val = d->regs[1].sien << 16;
> + break;
There's a similar unintended-sign-extension issue here (CID 1385145);
again, a cast should fix.
thanks
-- PMM
next prev parent reply other threads:[~2018-01-18 12:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 4:59 [Qemu-devel] [PULL 00/11] ppc-for-2.12 queue 20180111 David Gibson
2018-01-11 4:59 ` [Qemu-devel] [PULL 01/11] pseries: Update SLOF firmware image to qemu-slof-20171214 David Gibson
2018-01-11 4:59 ` [Qemu-devel] [PULL 02/11] sm501: Add panel hardware cursor registers also to read function David Gibson
2018-01-11 4:59 ` [Qemu-devel] [PULL 03/11] sm501: Add some more unimplemented registers David Gibson
2018-01-18 12:01 ` Peter Maydell
2018-01-19 1:44 ` BALATON Zoltan
2018-01-11 4:59 ` [Qemu-devel] [PULL 04/11] ppc4xx_i2c: Implement basic I2C functions David Gibson
2018-01-11 4:59 ` [Qemu-devel] [PULL 05/11] spapr_pci: use warn_report() David Gibson
2018-01-11 4:59 ` [Qemu-devel] [PULL 06/11] hw/ide: Emulate SiI3112 SATA controller David Gibson
2018-01-18 12:07 ` Peter Maydell
2018-01-19 1:48 ` BALATON Zoltan
2018-01-18 12:10 ` Peter Maydell [this message]
2018-03-06 18:32 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2018-03-06 23:30 ` BALATON Zoltan
2018-01-11 4:59 ` [Qemu-devel] [PULL 07/11] ppc/pnv: change powernv_ prefix to pnv_ for overall naming consistency David Gibson
2018-01-11 4:59 ` [Qemu-devel] [PULL 08/11] target/ppc: more use of the PPC_*() macros David Gibson
2018-01-11 4:59 ` [Qemu-devel] [PULL 09/11] Update dtc to fix compilation problem on Mac OS 10.6 David Gibson
2018-01-11 4:59 ` [Qemu-devel] [PULL 10/11] hw/ppc: Remove the deprecated spapr-pci-vfio-host-bridge device David Gibson
2018-01-11 4:59 ` [Qemu-devel] [PULL 11/11] spapr: Correct compatibility mode setting for hotplugged CPUs David Gibson
2018-01-11 14:34 ` [Qemu-devel] [PULL 00/11] ppc-for-2.12 queue 20180111 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA--Gdhs+tTwGWw2S9PNuDOriaGCFKSAnLrEPciQGmL_=Q@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=agraf@suse.de \
--cc=balaton@eik.bme.hu \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=surajjs@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).