From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <rth@twiddle.net>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] tcg: Use bitmaps for free temporaries
Date: Sat, 7 Dec 2013 17:18:57 +0000 [thread overview]
Message-ID: <CAFEAcA--e1ynNDuJ0edRjrio2crGCGOK5qo496aa1wtTNbh2tA@mail.gmail.com> (raw)
In-Reply-To: <1379620717-20358-1-git-send-email-rth@twiddle.net>
On 19 September 2013 20:58, Richard Henderson <rth@twiddle.net> wrote:
> We previously allocated 32-bits per temp for the next_free_temp entry.
> We now allocate 4 bits per temp across the 4 bitmaps.
>
> Using a linked list meant that if a translator is tweeked, resulting in
> temps being freed in a different order, that would have follow-on effects
> throughout the TB. Always allocating the lowest free temp means that
> follow-on effects are minimized, which can make it easier to diff output
> when debugging the translators.
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
next prev parent reply other threads:[~2013-12-07 17:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 19:58 [Qemu-devel] [PATCH] tcg: Use bitmaps for free temporaries Richard Henderson
2013-11-19 6:57 ` Richard Henderson
2013-12-06 17:47 ` Richard Henderson
2013-12-07 17:18 ` Peter Maydell [this message]
2013-12-08 13:48 ` Aurelien Jarno
2013-12-09 19:23 ` Richard Henderson
2013-12-10 10:28 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA--e1ynNDuJ0edRjrio2crGCGOK5qo496aa1wtTNbh2tA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).