From: Peter Maydell <peter.maydell@linaro.org>
To: i.mitsyanko@samsung.com
Cc: e.voevodin@samsung.com, quintela@redhat.com,
qemu-devel@nongnu.org, kyungmin.park@samsung.com,
d.solodkiy@samsung.com, m.kozlov@samsung.com,
jehyung.lee@samsung.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH V2 2/3] hw/sd.c: add SD card save/load support
Date: Wed, 28 Dec 2011 14:41:04 +0000 [thread overview]
Message-ID: <CAFEAcA--qJr51xXFFnFPei16fBjF0nAARELuCuNByW+ZKQ_f0A@mail.gmail.com> (raw)
In-Reply-To: <4EFB2162.1090702@samsung.com>
On 28 December 2011 14:02, Mitsyanko Igor <i.mitsyanko@samsung.com> wrote:
> On 12/28/2011 05:26 PM, Peter Maydell wrote:
>> Also, why should we care particularly about the order of
>> fields in SDState? There will be at most a handful of copies
>> of this struct in qemu, costing a handful of bytes in extra
>> padding. ("ensure proper data alignment" is wrong -- the compiler
>> does this for us.) If you feel you must rearrange things, again,
>> please put it in a separate patch so it's easier to read.
>>
> Why not, it wouldn't hurt anyone.
Basically I think this is pointless microoptimisation. If you
haven't measured something and determined that this is a useful
change because it makes things faster or usefully decreases
memory use by some non-trivial amount, then this kind of change
is a poor use of your time and also mine (as reviewer) and of
whoever eventually commits the patch to git.
-- PMM
next prev parent reply other threads:[~2011-12-28 14:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 10:03 [Qemu-devel] [PATCH 0/3] Improve SD controllers emulation Mitsyanko Igor
2011-12-26 10:03 ` [Qemu-devel] [PATCH 1/3] vmstate: introduce calc_size VMStateField Mitsyanko Igor
2011-12-26 15:20 ` Peter Maydell
2011-12-27 8:11 ` Mitsyanko Igor
2011-12-27 13:10 ` Andreas Färber
2011-12-28 7:41 ` Mitsyanko Igor
2011-12-27 7:54 ` [Qemu-devel] [PATCH V2 1/3] vmstate: introduce get_bufsize entry in VMStateField Mitsyanko Igor
2011-12-26 10:03 ` [Qemu-devel] [PATCH 2/3] hw/sd.c: add SD card save/load support Mitsyanko Igor
2011-12-26 14:58 ` Peter Maydell
2011-12-27 11:27 ` Mitsyanko Igor
2011-12-27 13:27 ` Andreas Färber
2011-12-27 13:54 ` Mitsyanko Igor
2011-12-27 14:13 ` Avi Kivity
2011-12-27 21:30 ` Peter Maydell
2011-12-28 9:50 ` Avi Kivity
2011-12-26 10:03 ` [Qemu-devel] [PATCH 3/3] hw/: Introduce spec. ver. 2.00 compliant SD host controller Mitsyanko Igor
2011-12-26 11:35 ` malc
2011-12-28 12:08 ` [Qemu-devel] [PATCH V2 0/3] Improve SD controllers emulation Mitsyanko Igor
2011-12-28 12:08 ` [Qemu-devel] [PATCH V2 1/3] vmstate: introduce get_bufsize entry in VMStateField Mitsyanko Igor
2011-12-28 12:08 ` [Qemu-devel] [PATCH V2 2/3] hw/sd.c: add SD card save/load support Mitsyanko Igor
2011-12-28 13:26 ` Peter Maydell
2011-12-28 14:02 ` Mitsyanko Igor
2011-12-28 14:41 ` Peter Maydell [this message]
2011-12-28 12:08 ` [Qemu-devel] [PATCH V2 3/3] hw: Introduce spec. ver. 2.00 compliant SD host controller Mitsyanko Igor
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 0/5] Improve SD controllers emulation Mitsyanko Igor
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 1/5] vmstate: introduce get_bufsize entry in VMStateField Mitsyanko Igor
2012-01-19 13:40 ` Andreas Färber
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 2/5] hw/sd.c: add SD card save/load support Mitsyanko Igor
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 3/5] hw/sd.c: convert wp_groups, expecting_acmd and enable to bool Mitsyanko Igor
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 4/5] hw/sd.c: convert wp_switch and spi " Mitsyanko Igor
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 5/5] hw: Introduce spec. ver. 2.00 compliant SD host controller Mitsyanko Igor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA--qJr51xXFFnFPei16fBjF0nAARELuCuNByW+ZKQ_f0A@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=i.mitsyanko@samsung.com \
--cc=jehyung.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=m.kozlov@samsung.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).