From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZIZs-0001tw-W4 for qemu-devel@nongnu.org; Fri, 26 Feb 2016 08:37:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZIZp-0002Wx-5N for qemu-devel@nongnu.org; Fri, 26 Feb 2016 08:37:04 -0500 Received: from mail-vk0-x234.google.com ([2607:f8b0:400c:c05::234]:35588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZIZo-0002Vh-La for qemu-devel@nongnu.org; Fri, 26 Feb 2016 08:37:01 -0500 Received: by mail-vk0-x234.google.com with SMTP id e6so77030684vkh.2 for ; Fri, 26 Feb 2016 05:37:00 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1456490739-19343-1-git-send-email-edgar.iglesias@gmail.com> References: <1456490739-19343-1-git-send-email-edgar.iglesias@gmail.com> From: Peter Maydell Date: Fri, 26 Feb 2016 13:36:40 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v1 1/1] target-arm: Mark CNTHP_TVAL_EL2 as ARM_CP_NO_RAW List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" Cc: Edgar Iglesias , qemu-arm , QEMU Developers On 26 February 2016 at 12:45, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Mark CNTHP_TVAL_EL2 as ARM_CP_NO_RAW due to the register not > having any underlying state. This fixes an issue with booting > KVM enabled kernels when EL2 is on. > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-arm/helper.c b/target-arm/helper.c > index 85a6685..601e3c1 100644 > --- a/target-arm/helper.c > +++ b/target-arm/helper.c > @@ -3631,7 +3631,7 @@ static const ARMCPRegInfo el2_cp_reginfo[] = { > .writefn = gt_hyp_cval_write, .raw_writefn = raw_write }, > { .name = "CNTHP_TVAL_EL2", .state = ARM_CP_STATE_BOTH, > .opc0 = 3, .opc1 = 4, .crn = 14, .crm = 2, .opc2 = 0, > - .type = ARM_CP_IO, .access = PL2_RW, > + .type = ARM_CP_NO_RAW | ARM_CP_IO, .access = PL2_RW, > .resetfn = gt_hyp_timer_reset, > .readfn = gt_hyp_tval_read, .writefn = gt_hyp_tval_write }, > { .name = "CNTHP_CTL_EL2", .state = ARM_CP_STATE_BOTH, > -- Applied to target-arm.next, thanks. -- PMM