qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Attila-Mihaly Balazs <dify.ltd@gmail.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Possible security enhancement for QEMU
Date: Mon, 5 Jan 2015 18:20:12 +0000	[thread overview]
Message-ID: <CAFEAcA--yDRwXuCLRtEmeEGEye1WMAnUpXJ-jje6MEpFSSWcAw@mail.gmail.com> (raw)
In-Reply-To: <20150105181354.GN29381@redhat.com>

On 5 January 2015 at 18:13, Daniel P. Berrange <berrange@redhat.com> wrote:
> Configuring 0.0.0.0 and no auth is a valid setup *provided* the virtualization
> host itself is on a secured network. In fact this is the normal setup for an
> OpenStack deployment, since the virt host/VNC server is not intended to ever
> be directly exposed to the internet. Instead the user accesses the VNC server
> via an authenticated VNC proxy tunnelled over HTTPs. So printing out such an
> error message or refusing to launch would be wrong - QEMU doesn't know the
> context of how it is being used.

Well, the question is what the default should be, and whether you should
have to take explicit action to enable a possibly-insecure configuration.
At the moment you don't, and this seems to have resulted in a lot of
people presumably unintentionally leaving themselves wide open to
access from the internet.

So it comes down to "are we willing to one-time break currently working
configs for people with openstack type deployments who will now need to
put no-auth-is-ok in their command line switches, in order to protect
new users against shooting themselves in the foot without realising it?".
You could argue it either way...

>> Seems reasonable to me. Some questions:
>>  * do we need an option for "yes, I know what I'm doing and do not
>>    want any authentication" ?
>>  * how many of these VMs are configured for wide-open VNC by libvirt or
>>    similar management tool rather than by the user directly running QEMU?
>
> Libvirt will always set the listen address to 127.0.0.1 if not otherwise
> specified, and so not rely on QEMU's (insecure) default.  So if any VMs
> managed by libvirt are using a public IP address, this was requested
> explicitly by the admin or the mgmt app using libvrt.

That's good to hear.

-- PMM

      reply	other threads:[~2015-01-05 18:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-29 19:09 [Qemu-devel] Possible security enhancement for QEMU Attila-Mihaly Balazs
2014-12-29 21:26 ` Peter Maydell
2015-01-05 18:13   ` Daniel P. Berrange
2015-01-05 18:20     ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA--yDRwXuCLRtEmeEGEye1WMAnUpXJ-jje6MEpFSSWcAw@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=berrange@redhat.com \
    --cc=dify.ltd@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).