Re: [Qemu-devel] [PATCH v2] gdb: provide the name of the architecture in the target.xml

[Peter Maydell <peter.maydell@linaro.org>]

On 14 January 2016 at 14:27, Christian Borntraeger
<borntraeger@de.ibm.com> wrote:
> Ping?
>
> On 12/03/2015 01:14 PM, Christian Borntraeger wrote:
>> From: David Hildenbrand <dahi@linux.vnet.ibm.com>
>>
>> This patch provides the name of the architecture in the target.xml
>> if available.
>>
>> This allows the remote gdb to detect the target architecture on its
>> own - so there is no need to specify it manually (e.g. if gdb is
>> started without a binary) using "set arch *arch_name*".
>>
>> The name of the architecture is provided by a callback that can
>> be implemented by all architectures. The arm implementation has
>> special handling for iwmmxt and returns arm otherwise. This can
>> be extended if necessary.
>>
>> Signed-off-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
>> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> [rework to use a callback]
>> ---
>> v1->v2: replace the fixed string with a callback
>>
>>  gdbstub.c                   | 21 ++++++++++++++-------
>>  include/qom/cpu.h           |  3 +++
>>  target-arm/cpu.c            | 12 ++++++++++++
>>  target-arm/cpu64.c          |  6 ++++++
>>  target-ppc/translate_init.c | 10 ++++++++++
>>  target-s390x/cpu.c          |  6 ++++++
>>  6 files changed, 51 insertions(+), 7 deletions(-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

(at least for the generic and ARM related bits).

thanks
-- PMM