From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46523)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZDEkX-0006nF-S3
	for qemu-devel@nongnu.org; Thu, 09 Jul 2015 12:32:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZDEkT-0001fX-RF
	for qemu-devel@nongnu.org; Thu, 09 Jul 2015 12:32:37 -0400
Received: from mail-vn0-f41.google.com ([209.85.216.41]:36864)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZDEkT-0001fO-Nf
	for qemu-devel@nongnu.org; Thu, 09 Jul 2015 12:32:33 -0400
Received: by vnav203 with SMTP id v203so16377399vna.4
	for <qemu-devel@nongnu.org>; Thu, 09 Jul 2015 09:32:33 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAFEAcA_krVmWpix4nhGufgaWeAPc32MeLhQjT6abgF4+ZYq8uQ@mail.gmail.com>
References: <1436448252-1916-1-git-send-email-afaerber@suse.de>
	<CAFEAcA_krVmWpix4nhGufgaWeAPc32MeLhQjT6abgF4+ZYq8uQ@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 9 Jul 2015 17:32:13 +0100
Message-ID: <CAFEAcA-1-Xzrg6mg+tSTVUv0j5EVpBR9DFnw7u-P_SOkBHecmw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL v3 00/22] QOM CPUState patch queue 2015-07-09
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, QEMU Developers <qemu-devel@nongnu.org>, Eduardo Habkost <ehabkost@redhat.com>

On 9 July 2015 at 16:22, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 9 July 2015 at 14:23, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> Hello Peter,
>>
>> This is my QOM CPU patch queue. Please pull.
>>
>> v3 fixes ppc and linux-user related bugs.
>>
>> Regards,
>> Andreas
>>
>> Cc: Peter Maydell <peter.maydell@linaro.org>
>>
>> Cc: Eduardo Habkost <ehabkost@redhat.com>
>> Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>>
>> The following changes since commit acf7b7fdf31fa76b53803790917c8acf23a2b=
adb:
>>
>>   Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into =
staging (2015-07-08 20:46:35 +0100)
>>
>> are available in the git repository at:
>>
>>   git://github.com/afaerber/qemu-cpu.git tags/qom-cpu-for-peter
>>
>> for you to fetch changes up to 6b625fde5eb8d1c969969392f1c92b58beed2183:
>>
>>   disas: cris: QOMify target specific disas setup (2015-07-09 15:20:41 +=
0200)
>>
>> ----------------------------------------------------------------
>> QOM CPUState and X86CPU
>>
>> * Further QOM'ification of CPU initialization
>> * Propagation of CPUState arguments and elimination of ENV_GET_CPU() usa=
ge
>> * cpu_set_pc() abstraction
>> * CPUClass::disas_set_info() hook
>>
>
> Applied, thanks.

...but it turns out to have broken compiling TCI:

  CC    x86_64-softmmu/arch_init.o
In file included from
/home/petmay01/linaro/qemu-for-merges/target-i386/cpu-qom.h:23:0,
                 from
/home/petmay01/linaro/qemu-for-merges/target-i386/cpu.h:986,
                 from
/home/petmay01/linaro/qemu-for-merges/include/qemu-common.h:122,
                 from
/home/petmay01/linaro/qemu-for-merges/include/disas/bfd.h:12,
                 from /home/petmay01/linaro/qemu-for-merges/disas/tci.c:20:
/home/petmay01/linaro/qemu-for-merges/include/qom/cpu.h:178:43: error:
unknown type name =E2=80=98disassemble_info=E2=80=99
     void (*disas_set_info)(CPUState *cpu, disassemble_info *info);
                                           ^
/home/petmay01/linaro/qemu-for-merges/include/qom/cpu.h:179:1: error:
no semicolon at end of struct or union [-Werror]
 } CPUClass;
 ^
cc1: all warnings being treated as errors

Maybe I should put that config in my standard build test set...

-- PMM