From: Peter Maydell <peter.maydell@linaro.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Juan Quintela <quintela@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [RFC for-next 0/2] QOM VMStateDescription remix
Date: Fri, 7 Feb 2014 21:39:08 +0000 [thread overview]
Message-ID: <CAFEAcA-1MetNObyzZu++K5xN=1fM2-V73DOCFFqkLmxjXCNhsw@mail.gmail.com> (raw)
In-Reply-To: <52F55006.1030509@suse.de>
On 7 February 2014 21:28, Andreas Färber <afaerber@suse.de> wrote:
> I have found a single such case: armv7m_nvic overrides arm_gic_common
> with a completely different vmsd. How can we fix that? :)
We can deduce from this that nobody's been using migration
with the Cortex-M3, since it would obviously be totally busted.
So the answer is "any way you like". The M profile code in
QEMU is not really maintained; mostly I just accept patches
that don't make things worse.
What the code is presumably attempting to do is add the
extra fields for the systick timer on top of the base state
for the interrupt controller. Personally I'd be tempted to
split systick out into its own little device. (It's only bundled
in with the NVIC because this code predates memory
regions and at the time you couldn't really do the system
register region any other way.)
thanks
-- PMM
prev parent reply other threads:[~2014-02-07 21:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 2:03 [Qemu-devel] [RFC for-next 0/2] QOM VMStateDescription remix Andreas Färber
2013-07-29 2:03 ` [Qemu-devel] [RFC for-next 1/2] qdev: Construct VMStateDescription from type hierarchy Andreas Färber
2013-07-29 2:03 ` [Qemu-devel] [RFC for-next 2/2] cpu: Move VMSTATE_CPU() into TYPE_CPU VMStateDescription Andreas Färber
2013-07-29 4:30 ` Jia Liu
2013-09-02 11:28 ` [Qemu-devel] [RFC for-next 0/2] QOM VMStateDescription remix Andreas Färber
2013-09-02 11:41 ` Michael S. Tsirkin
2014-02-07 21:28 ` Andreas Färber
2014-02-07 21:39 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-1MetNObyzZu++K5xN=1fM2-V73DOCFFqkLmxjXCNhsw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).