Re: [PATCH] ci: migration: Don't run python tests in the compat job

[Peter Maydell <peter.maydell@linaro.org>]

On Thu, 5 Sept 2024 at 20:34, Fabiano Rosas <farosas@suse.de> wrote:
>
> Peter Xu <peterx@redhat.com> writes:
>
> > On Thu, Sep 05, 2024 at 03:54:45PM -0300, Fabiano Rosas wrote:
> >> The vmstate-checker-script test has a bug that makes it flaky. It was
> >> also committed by mistake and will be removed.
> >>
> >> Since the migration-compat job takes the tests from the build-previous
> >> job instead of the current HEAD, neither a fix or a removal of the
> >> test will take effect for this release.
> >>
> >> Disable the faulty/undesirable test by taking advantage that it only
> >> runs if the PYTHON environment variable is set. This also disables the
> >> analyze-migration-script test, but this is fine because that test
> >> doesn't have migration compatibility implications.
> >>
> >> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> >
> > Reviewed-by: Peter Xu <peterx@redhat.com>
> >
> > We should still merge your previous pull, right?  Looks like that's the
> > easiest indeed.
>
> As I mentioned there, that pull is not to blame for this situation, so
> my recommendation is to merge. However, there is still the suppression
> of the deprecation messages that Peter asked about. I'll send a series
> for that in a moment, but it requires qtest changes and probably a lot
> of discussion.

Looking at logs for other things I've merged, those deprecation
messages are already upstream. So I'm OK with giving your
pullreq as it stands another attempt at a merge.

thanks
-- PMM