From: Peter Maydell <peter.maydell@linaro.org>
To: Gan Qixin <ganqixin@huawei.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"QEMU Trivial" <qemu-trivial@nongnu.org>,
"Markus Armbruster" <armbru@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Chenqun (kuhn)" <kuhn.chenqun@huawei.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>
Subject: Re: [PATCH v3 2/4] ads7846: put it into the 'input' category
Date: Fri, 13 Nov 2020 10:12:31 +0000 [thread overview]
Message-ID: <CAFEAcA-30x8FS8Kmz3AzvJAR0z7_7utAfPEhCTYmq-dvKW9wFA@mail.gmail.com> (raw)
In-Reply-To: <20201112125824.763182-3-ganqixin@huawei.com>
On Fri, 13 Nov 2020 at 03:32, Gan Qixin <ganqixin@huawei.com> wrote:
>
> The category of the ads7846 device is not set, put it into the 'input'
> category.
>
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
> Cc: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/display/ads7846.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/display/ads7846.c b/hw/display/ads7846.c
> index 023165b2a3..cb3a431cfd 100644
> --- a/hw/display/ads7846.c
> +++ b/hw/display/ads7846.c
> @@ -163,10 +163,12 @@ static void ads7846_realize(SSISlave *d, Error **errp)
>
> static void ads7846_class_init(ObjectClass *klass, void *data)
> {
> + DeviceClass *dc = DEVICE_CLASS(klass);
> SSISlaveClass *k = SSI_SLAVE_CLASS(klass);
>
> k->realize = ads7846_realize;
> k->transfer = ads7846_transfer;
> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> }
>
> static const TypeInfo ads7846_info = {
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Really we should move the file too...
thanks
-- PMM
next prev parent reply other threads:[~2020-11-13 10:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 12:58 [PATCH v3 0/4] Categorize some uncategorized devices Gan Qixin
2020-11-12 12:58 ` [PATCH v3 1/4] ssd0323: put it into the 'display' category Gan Qixin
2020-11-16 12:45 ` Philippe Mathieu-Daudé
2020-11-12 12:58 ` [PATCH v3 2/4] ads7846: put it into the 'input' category Gan Qixin
2020-11-13 10:12 ` Peter Maydell [this message]
2020-11-13 11:14 ` ganqixin
2020-11-16 12:46 ` Philippe Mathieu-Daudé
2020-11-12 12:58 ` [PATCH v3 3/4] nand: put it into the 'storage' category Gan Qixin
2020-11-16 12:45 ` Philippe Mathieu-Daudé
2020-11-12 12:58 ` [PATCH v3 4/4] max111x: put it into the 'misc' category Gan Qixin
2020-11-13 7:14 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-30x8FS8Kmz3AzvJAR0z7_7utAfPEhCTYmq-dvKW9wFA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=ganqixin@huawei.com \
--cc=kuhn.chenqun@huawei.com \
--cc=laurent@vivier.eu \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).