From: Peter Maydell <peter.maydell@linaro.org>
To: Aleksandar Markovic <amarkovic@wavecomp.com>
Cc: Mateja Marjanovic <mateja.marjanovic@rt-rk.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"aurelien@aurel32.net" <aurelien@aurel32.net>,
Aleksandar Rikalo <arikalo@wavecomp.com>,
"alex.bennee@linaro.org" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU
Date: Mon, 11 Mar 2019 12:50:13 +0000 [thread overview]
Message-ID: <CAFEAcA-5D7nHBgb2hY+BT6CtTbt_qBQUL1KdLsoQLWsfyvRt6Q@mail.gmail.com> (raw)
In-Reply-To: <BN6PR2201MB1251FE1DD4630A150FFA1747C6480@BN6PR2201MB1251.namprd22.prod.outlook.com>
On Mon, 11 Mar 2019 at 11:52, Aleksandar Markovic
<amarkovic@wavecomp.com> wrote:
>
> > From: Mateja Marjanovic <mateja.marjanovic@rt-rk.com>
> > Subject: [PATCH] target/mips: Fix minor bug in FPU
> >
> > Wrong type of NaN was generated by maddf and msubf insturctions
> > when the arguments were inf, zero, nan or zero, inf, nan
> > respectively.
>
> I did the applicable tests on both pre-NaN2008 and NaN2008 MIPS hardware,
> and compared results with QEMu emulations. The underlying reason for this
> patch is correct, but, as Alex also pointed out, it needs some improvements.
> However, the softfreeze being so close, I am going to amend the patch while
> creating the pull request. No respin needed. All in all:
Since this is a bug fix, there is no requirement that it goes in
before softfreeze, FWIW -- pretty much any bug fix is OK for
rc1, and a focused bugfix like this one that doesn't affect
other guest architectures would be ok in rc2 as well.
thanks
-- PMM
next prev parent reply other threads:[~2019-03-11 12:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 17:10 [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU Mateja Marjanovic
2019-03-07 17:10 ` Mateja Marjanovic
2019-03-07 17:32 ` Alex Bennée
2019-03-07 17:43 ` Aleksandar Markovic
2019-03-07 18:25 ` Alex Bennée
2019-03-11 11:52 ` Aleksandar Markovic
2019-03-11 12:50 ` Peter Maydell [this message]
2019-03-11 13:58 ` Aleksandar Markovic
2019-03-11 14:18 ` Alex Bennée
2019-03-11 14:35 ` Aleksandar Markovic
2019-03-11 14:48 ` Peter Maydell
2019-03-11 15:18 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-5D7nHBgb2hY+BT6CtTbt_qBQUL1KdLsoQLWsfyvRt6Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=amarkovic@wavecomp.com \
--cc=arikalo@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=mateja.marjanovic@rt-rk.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).