From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55603)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1agD5b-0005yL-DM
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 11:10:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1agD5Z-0004A5-Ou
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 11:10:23 -0400
Received: from mail-vk0-x22c.google.com ([2607:f8b0:400c:c05::22c]:32931)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1agD5Z-00049y-Hr
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 11:10:21 -0400
Received: by mail-vk0-x22c.google.com with SMTP id k1so65556208vkb.0
	for <qemu-devel@nongnu.org>; Wed, 16 Mar 2016 08:10:21 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20160302105553.GB11268@stefanha-x1.localdomain>
References: <145625172744.12025.2350972792125742783.stgit@localhost>
	<20160302105553.GB11268@stefanha-x1.localdomain>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Wed, 16 Mar 2016 15:10:01 +0000
Message-ID: <CAFEAcA-5WdrUPKduLjFvu82uiTzUaPr-oTCiWFsxFiXdCb-RYg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 0/5] trace: Add events for vCPU memory
	accesses
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Richard Henderson <rth@twiddle.net>, =?UTF-8?Q?Llu=C3=ADs_Vilanova?= <vilanova@ac.upc.edu>, Stefan Hajnoczi <stefanha@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On 2 March 2016 at 10:55, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Tue, Feb 23, 2016 at 07:22:07PM +0100, Llu=C3=ADs Vilanova wrote:
>> NOTE: This series applies on top of "trace: Show vCPU info in guest code=
 events"
>>
>> This series adds to new events:
>>
>> * guest_vmem: memory accesses performed by vCPUs (guest code)
>>
>> * guest_vmem_user_syscall: memory accesses performed by syscall emulatio=
n when
>>   running QEMU in user-mode.
>>
>> Signed-off-by: Llu=C3=ADs Vilanova <vilanova@ac.upc.edu>
>> ---
>>
>> Llu=C3=ADs Vilanova (5):
>>       exec: [tcg] Track which vCPU is performing translation and executi=
on
>>       trace: [all] Add "guest_vmem" event
>>       user: Refactor lock_user body into do_lock_user
>>       user: Set current vCPU during syscall execution
>>       trace: [all] Add "guest_vmem_user_syscall" event

> Any comments from TCG folks?

The first two patches which add TCG guest data access tracing look
OK to me, but I'm much less sure about the last three which are
adding tracing into linux-user syscall emulation. I'm not sure
that lock_user is the right place to put that tracepoint.

thanks
-- PMM