From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiTgm-0001PC-5W for qemu-devel@nongnu.org; Tue, 11 Dec 2012 12:32:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TiTgk-0006JG-Pb for qemu-devel@nongnu.org; Tue, 11 Dec 2012 12:32:16 -0500 Received: from mail-ie0-f173.google.com ([209.85.223.173]:44404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiTgk-0006J7-L0 for qemu-devel@nongnu.org; Tue, 11 Dec 2012 12:32:14 -0500 Received: by mail-ie0-f173.google.com with SMTP id e13so12577342iej.4 for ; Tue, 11 Dec 2012 09:32:13 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1355157952-2321-9-git-send-email-fred.konrad@greensocs.com> References: <1355157952-2321-1-git-send-email-fred.konrad@greensocs.com> <1355157952-2321-9-git-send-email-fred.konrad@greensocs.com> Date: Tue, 11 Dec 2012 17:32:13 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [RFC PATCH v7 8/8] virtio-blk : QOM modifications. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com Cc: aliguori@us.ibm.com, e.voevodin@samsung.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, stefanha@redhat.com, cornelia.huck@de.ibm.com, afaerber@suse.de On 10 December 2012 16:45, wrote: > From: KONRAD Frederic > > As the virtio-blk-pci is switched to the new API, we can use QOM casts and > remove the separate init for the old API. This patch effectively breaks virtio_blk_init() [because it removes the code path that handles s==NULL] but it does not actually remove that function, so it has not completely cleaned up the legacy code. It should be possible to inline the virtio_blk_common_init() function into virtio_device_init() then. We should end up with all the legacy stuff removed so the only APIs for manipulating virtio-blk are the qdev ones. Also some cleanup patch somewhere needs to get rid of the function pointers in VirtIODevice. (If the cleanup phase looks like it would be a bit hard to understand done as a single patch, feel free to split it suitably.) Incidentally this patch should probably have a note in the commit message that it's only intended to be applied after conversion of all the transports (ie of s390). Basically you need to keep going here to actually finish the demonstration of what the final cleaned up transport and backend look like. -- PMM