From: Peter Maydell <peter.maydell@linaro.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Wanpeng Li" <liwp@linux.vnet.ibm.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH RFC 0/3] qom: Generalize qdev init to "realize"
Date: Tue, 27 Mar 2012 17:33:38 +0100 [thread overview]
Message-ID: <CAFEAcA-672g0AmQJSy-2Sfd3roKDNtoDx9xMwcZ-TxMgppir5w@mail.gmail.com> (raw)
In-Reply-To: <4F71EABB.1030004@codemonkey.ws>
On 27 March 2012 17:28, Anthony Liguori <anthony@codemonkey.ws> wrote:
> On 03/27/2012 11:19 AM, Paolo Bonzini wrote:
>> I think a major difference between realize and init should be that the
>> realize property also propagates down the whole composition tree (in
>> pre-order for setting to true, and post-order for setting to false).
>
>
> Yes, I haven't reviewed this series yet, but my expectation would be that
> realize propagates and that the default implementation of
> DeviceClass::realize() would explicitly *not* propagate and instead just
> call ::init.
So who calls realize for non-qdev QOM objects which are children of
qdev QOM objects?
I really don't like having the object lifecycle methods be different
for DeviceClass than for base objects if we can avoid it.
-- PMM
next prev parent reply other threads:[~2012-03-27 16:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 13:46 [Qemu-devel] [PATCH RFC 0/3] qom: Generalize qdev init to "realize" Andreas Färber
2012-03-26 13:46 ` [Qemu-devel] [PATCH RFC 1/3] qom: Add "realized" property to Object Andreas Färber
2012-03-26 15:07 ` Andreas Färber
2012-03-27 9:25 ` Stefan Hajnoczi
2012-03-26 13:46 ` [Qemu-devel] [PATCH RFC 2/3] qom: Introduce object_realize() Andreas Färber
2012-03-26 13:46 ` [Qemu-devel] [PATCH RFC 3/3] qdev: Hook up DeviceClass::init to ObjectClass::realize Andreas Färber
2012-03-26 13:54 ` Andreas Färber
2012-03-27 16:19 ` [Qemu-devel] [PATCH RFC 0/3] qom: Generalize qdev init to "realize" Paolo Bonzini
2012-03-27 16:28 ` Anthony Liguori
2012-03-27 16:33 ` Peter Maydell [this message]
2012-03-27 16:46 ` Paolo Bonzini
2012-03-27 18:56 ` Anthony Liguori
2012-03-27 16:41 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-672g0AmQJSy-2Sfd3roKDNtoDx9xMwcZ-TxMgppir5w@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=liwp@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).