From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCZL9-0005fk-OL for qemu-devel@nongnu.org; Tue, 27 Mar 2012 12:33:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCZL3-0001Eq-AN for qemu-devel@nongnu.org; Tue, 27 Mar 2012 12:33:47 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:56354) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCZL3-0001Ea-54 for qemu-devel@nongnu.org; Tue, 27 Mar 2012 12:33:41 -0400 Received: by iafj26 with SMTP id j26so133687iaf.4 for ; Tue, 27 Mar 2012 09:33:38 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4F71EABB.1030004@codemonkey.ws> References: <1332769612-4247-1-git-send-email-afaerber@suse.de> <4F71E8AE.9030504@redhat.com> <4F71EABB.1030004@codemonkey.ws> Date: Tue, 27 Mar 2012 17:33:38 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH RFC 0/3] qom: Generalize qdev init to "realize" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Paolo Bonzini , Wanpeng Li , =?UTF-8?Q?Andreas_F=C3=A4rber?= On 27 March 2012 17:28, Anthony Liguori wrote: > On 03/27/2012 11:19 AM, Paolo Bonzini wrote: >> I think a major difference between realize and init should be that the >> realize property also propagates down the whole composition tree (in >> pre-order for setting to true, and post-order for setting to false). > > > Yes, I haven't reviewed this series yet, but my expectation would be that > realize propagates and that the default implementation of > DeviceClass::realize() would explicitly *not* propagate and instead just > call ::init. So who calls realize for non-qdev QOM objects which are children of qdev QOM objects? I really don't like having the object lifecycle methods be different for DeviceClass than for base objects if we can avoid it. -- PMM