qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] loader: don't perform overlapping address check for memory region ROM images
Date: Fri, 23 Feb 2018 18:04:35 +0000	[thread overview]
Message-ID: <CAFEAcA-6KuJe17cHNVUzaKT30uv7bBS52ctoNxS0u9Mfp_HtXg@mail.gmail.com> (raw)
In-Reply-To: <20180223112933.4135-1-mark.cave-ayland@ilande.co.uk>

On 23 February 2018 at 11:29, Mark Cave-Ayland
<mark.cave-ayland@ilande.co.uk> wrote:
> All memory region ROM images have a base address of 0 which causes the overlapping
> address check to fail if more than one memory region ROM image is present, or an
> existing ROM image is loaded at address 0.
>
> Make sure that we ignore the overlapping address check in
> rom_check_and_register_reset() if this is a memory region ROM image. In particular
> this fixes the "rom: requested regions overlap" error on startup when trying to
> run qemu-system-sparc with a -kernel image since commit 7497638642: "tcx: switch to
> load_image_mr() and remove prom_addr hack".
>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Do you want to take this via your sparc tree?

thanks
-- PMM

  reply	other threads:[~2018-02-23 18:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-23 11:29 [Qemu-devel] [PATCH] loader: don't perform overlapping address check for memory region ROM images Mark Cave-Ayland
2018-02-23 18:04 ` Peter Maydell [this message]
2018-02-23 18:53   ` Mark Cave-Ayland
2018-02-23 18:53     ` Peter Maydell
2018-02-27 19:19       ` Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA-6KuJe17cHNVUzaKT30uv7bBS52ctoNxS0u9Mfp_HtXg@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).