From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: John Snow <jsnow@redhat.com>, Fam Zheng <famz@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Patch checking bot
Date: Mon, 20 Oct 2014 15:08:35 +0100 [thread overview]
Message-ID: <CAFEAcA-6XnjSdbEBmznpR3obXWVLN=SAiB_MeELYYbbTHAxjuQ@mail.gmail.com> (raw)
In-Reply-To: <20141020102559.GA29278@stefanha-thinkpad.redhat.com>
On 20 October 2014 11:25, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> Hi,
> At KVM Forum 2014 we discussed a patch checking bot that automates patch
> format checking and smoke testing:
>
> 1. Did the patch submitter include Signed-off-by?
> 2. Does checkpatch.pl pass?
> 3. Does the patch apply to qemu.git/master?
> 4. Does each patch compile?
> 5. Does the series pass make check and qemu-iotests?
>
> Here are some thoughts on the patch checker:
>
> If a patch series passes successfully, no email is sent. If a patch
> series fails, an email with the errors is sent as a reply to the patch
> series email thread. The patch submitter can then respond in case there
> are false positive (e.g. from checkpatch.pl) - the bot doesn't care
> about replies but it tells the human reviewers and maintainers what the
> patch submitter intends to do.
Probably also worth having a feature where the cover
letter or patch can have a "patchchecker: no" line in
it to tell the bot to ignore something, so people can
avoid it sending lots of mail for patch series they
know don't apply to mainline (eg ones which depend on
a previous series).
-- PMM
next prev parent reply other threads:[~2014-10-20 14:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 10:25 [Qemu-devel] Patch checking bot Stefan Hajnoczi
2014-10-20 14:08 ` Peter Maydell [this message]
2014-10-21 15:27 ` John Snow
2014-10-22 10:03 ` Stefan Hajnoczi
2014-10-27 18:25 ` Andreas Färber
2014-10-21 8:19 ` Fam Zheng
2014-10-22 10:08 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-6XnjSdbEBmznpR3obXWVLN=SAiB_MeELYYbbTHAxjuQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).