From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40362)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XgDdu-0007S0-Gn
	for qemu-devel@nongnu.org; Mon, 20 Oct 2014 10:09:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XgDdp-0004tq-3l
	for qemu-devel@nongnu.org; Mon, 20 Oct 2014 10:09:02 -0400
Received: from mail-la0-f49.google.com ([209.85.215.49]:62247)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XgDdo-0004tT-TP
	for qemu-devel@nongnu.org; Mon, 20 Oct 2014 10:08:57 -0400
Received: by mail-la0-f49.google.com with SMTP id q1so3951818lam.22
	for <qemu-devel@nongnu.org>; Mon, 20 Oct 2014 07:08:55 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20141020102559.GA29278@stefanha-thinkpad.redhat.com>
References: <20141020102559.GA29278@stefanha-thinkpad.redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 20 Oct 2014 15:08:35 +0100
Message-ID: <CAFEAcA-6XnjSdbEBmznpR3obXWVLN=SAiB_MeELYYbbTHAxjuQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] Patch checking bot
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: John Snow <jsnow@redhat.com>, Fam Zheng <famz@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On 20 October 2014 11:25, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> Hi,
> At KVM Forum 2014 we discussed a patch checking bot that automates patch
> format checking and smoke testing:
>
> 1. Did the patch submitter include Signed-off-by?
> 2. Does checkpatch.pl pass?
> 3. Does the patch apply to qemu.git/master?
> 4. Does each patch compile?
> 5. Does the series pass make check and qemu-iotests?
>
> Here are some thoughts on the patch checker:
>
> If a patch series passes successfully, no email is sent.  If a patch
> series fails, an email with the errors is sent as a reply to the patch
> series email thread.  The patch submitter can then respond in case there
> are false positive (e.g. from checkpatch.pl) - the bot doesn't care
> about replies but it tells the human reviewers and maintainers what the
> patch submitter intends to do.

Probably also worth having a feature where the cover
letter or patch can have a "patchchecker: no" line in
it to tell the bot to ignore something, so people can
avoid it sending lots of mail for patch series they
know don't apply to mainline (eg ones which depend on
a previous series).

-- PMM