From: Peter Maydell <peter.maydell@linaro.org>
To: Liviu Ionescu <ilg@livius.net>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] armv7m: optional -kernel if -gdb present
Date: Thu, 20 Nov 2014 12:50:20 +0000 [thread overview]
Message-ID: <CAFEAcA-6i-f_HyRc21KnEBAEPkEStR0ZDkkhPrtLd6y3a1136Q@mail.gmail.com> (raw)
In-Reply-To: <0834CF45-47D2-4ECD-AA51-2B4FB1F26DF9@livius.net>
On 20 November 2014 12:34, Liviu Ionescu <ilg@livius.net> wrote:
>
> On 20 Nov 2014, at 14:29, Peter Maydell <peter.maydell@linaro.org> wrote:
>
>>> - if (!kernel_filename && !qtest_enabled()) {
>>> + if (!kernel_filename && !qtest_enabled() && !with_gdb) {
>>> fprintf(stderr, "Guest image must be specified (using -kernel)\n");
>>> exit(1);
>>> }
>>
>> just delete this entire if() statement. This is how we've handled
>> similar issues with the ARM A profile boards. (Some of the boards
>> still have those checks but that's just because nobody's bothered
>> to fix them yet.)
>
> I'm a bit confused. if not running with gdb, what is the expected
> behaviour if the image is missing?
Same thing as if you start a hardware board with nothing loaded
into the flash. (Probably this means "go into an infinite loop
of taking exceptions".)
-- PMM
next prev parent reply other threads:[~2014-11-20 12:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 12:05 [Qemu-devel] [PATCH] armv7m: optional -kernel if -gdb present Liviu Ionescu
2014-11-20 12:29 ` Peter Maydell
2014-11-20 12:34 ` Liviu Ionescu
2014-11-20 12:50 ` Peter Maydell [this message]
2014-11-20 13:09 ` Liviu Ionescu
2014-11-20 13:20 ` Peter Maydell
2014-11-20 13:23 ` Liviu Ionescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-6i-f_HyRc21KnEBAEPkEStR0ZDkkhPrtLd6y3a1136Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=ilg@livius.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).