From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrRCA-0002LF-5Q for qemu-devel@nongnu.org; Thu, 20 Nov 2014 07:50:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrRC5-0008RP-Ne for qemu-devel@nongnu.org; Thu, 20 Nov 2014 07:50:46 -0500 Received: from mail-la0-f42.google.com ([209.85.215.42]:37803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrRC5-0008Qk-Ga for qemu-devel@nongnu.org; Thu, 20 Nov 2014 07:50:41 -0500 Received: by mail-la0-f42.google.com with SMTP id s18so2367988lam.15 for ; Thu, 20 Nov 2014 04:50:40 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <0834CF45-47D2-4ECD-AA51-2B4FB1F26DF9@livius.net> References: <1416485118-75534-1-git-send-email-ilg@livius.net> <0834CF45-47D2-4ECD-AA51-2B4FB1F26DF9@livius.net> From: Peter Maydell Date: Thu, 20 Nov 2014 12:50:20 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] armv7m: optional -kernel if -gdb present List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liviu Ionescu Cc: QEMU Developers On 20 November 2014 12:34, Liviu Ionescu wrote: > > On 20 Nov 2014, at 14:29, Peter Maydell wrote: > >>> - if (!kernel_filename && !qtest_enabled()) { >>> + if (!kernel_filename && !qtest_enabled() && !with_gdb) { >>> fprintf(stderr, "Guest image must be specified (using -kernel)\n"); >>> exit(1); >>> } >> >> just delete this entire if() statement. This is how we've handled >> similar issues with the ARM A profile boards. (Some of the boards >> still have those checks but that's just because nobody's bothered >> to fix them yet.) > > I'm a bit confused. if not running with gdb, what is the expected > behaviour if the image is missing? Same thing as if you start a hardware board with nothing loaded into the flash. (Probably this means "go into an infinite loop of taking exceptions".) -- PMM