From: Peter Maydell <peter.maydell@linaro.org>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/7] Move target_words_bigendian() prototype to exec-all.h
Date: Wed, 10 Dec 2014 19:44:04 +0000 [thread overview]
Message-ID: <CAFEAcA-7+AMnxr4c4AMC6W7xjLHWPpfMW5by7jRH8RJ_bcAw4Q@mail.gmail.com> (raw)
In-Reply-To: <1418239610-3997-2-git-send-email-ehabkost@redhat.com>
On 10 December 2014 at 19:26, Eduardo Habkost <ehabkost@redhat.com> wrote:
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> exec.c | 1 -
> hw/virtio/virtio.c | 1 -
> include/exec/exec-all.h | 2 ++
> 3 files changed, 2 insertions(+), 2 deletions(-)
I thought this prototype was deliberately not in a generally
included header file because it's really not something that
should be needed by most code. If we do want to move it into
a header then we definitely don't want it in exec-all.h.
thanks
-- PMM
next prev parent reply other threads:[~2014-12-10 19:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 19:26 [Qemu-devel] [PATCH v3 0/7] Target-specific unit test support, add unit tests for target-i386/cpu.c code Eduardo Habkost
2014-12-10 19:26 ` [Qemu-devel] [PATCH v3 1/7] Move target_words_bigendian() prototype to exec-all.h Eduardo Habkost
2014-12-10 19:44 ` Peter Maydell [this message]
2014-12-12 18:20 ` Eduardo Habkost
2014-12-15 9:30 ` Thomas Huth
2014-12-15 10:17 ` Greg Kurz
2014-12-10 19:26 ` [Qemu-devel] [PATCH v3 2/7] tests: Support target-specific unit tests Eduardo Habkost
2014-12-10 19:26 ` [Qemu-devel] [PATCH v3 3/7] tests: Make test-x86-cpuid target-specific Eduardo Habkost
2014-12-10 19:26 ` [Qemu-devel] [PATCH v3 4/7] tests: Add unit test for X86CPU code Eduardo Habkost
2014-12-10 19:26 ` [Qemu-devel] [PATCH v3 5/7] target-i386: Isolate enabled-by-default features to a separate array Eduardo Habkost
2014-12-10 19:26 ` [Qemu-devel] [PATCH v3 6/7] tests: test-x86-cpu: Add TCG feature bit initialization test Eduardo Habkost
2014-12-10 19:26 ` [Qemu-devel] [PATCH v3 7/7] tests: test-x86-cpu: Add KVM " Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-7+AMnxr4c4AMC6W7xjLHWPpfMW5by7jRH8RJ_bcAw4Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).