From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XynBY-0003uy-Df for qemu-devel@nongnu.org; Wed, 10 Dec 2014 14:44:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XynBR-00058V-OA for qemu-devel@nongnu.org; Wed, 10 Dec 2014 14:44:32 -0500 Received: from mail-la0-f48.google.com ([209.85.215.48]:38319) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XynBR-00058R-HP for qemu-devel@nongnu.org; Wed, 10 Dec 2014 14:44:25 -0500 Received: by mail-la0-f48.google.com with SMTP id gf13so3083854lab.35 for ; Wed, 10 Dec 2014 11:44:24 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1418239610-3997-2-git-send-email-ehabkost@redhat.com> References: <1418239610-3997-1-git-send-email-ehabkost@redhat.com> <1418239610-3997-2-git-send-email-ehabkost@redhat.com> From: Peter Maydell Date: Wed, 10 Dec 2014 19:44:04 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v3 1/7] Move target_words_bigendian() prototype to exec-all.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Paolo Bonzini , QEMU Developers , Igor Mammedov On 10 December 2014 at 19:26, Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkost > --- > exec.c | 1 - > hw/virtio/virtio.c | 1 - > include/exec/exec-all.h | 2 ++ > 3 files changed, 2 insertions(+), 2 deletions(-) I thought this prototype was deliberately not in a generally included header file because it's really not something that should be needed by most code. If we do want to move it into a header then we definitely don't want it in exec-all.h. thanks -- PMM