From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 1/3] tcg/sparc: Remove support for sparc32plus
Date: Sun, 30 Oct 2022 15:45:53 +0000 [thread overview]
Message-ID: <CAFEAcA-7q2fat9grNuTVcvzozTiCUBaPSSwqHLe02Dos7zFing@mail.gmail.com> (raw)
In-Reply-To: <20221017062445.563431-2-richard.henderson@linaro.org>
On Mon, 17 Oct 2022 at 07:44, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Since 9b9c37c36439, we have only supported sparc64 cpus.
> Debian and Gentoo now only support 64-bit sparc64 userland,
> so it is time to drop the 32-bit sparc64 userland: sparc32plus.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/sparc/tcg-target.h | 11 ---
> tcg/tcg.c | 75 +----------------
> tcg/sparc/tcg-target.c.inc | 166 +++++++------------------------------
> 3 files changed, 33 insertions(+), 219 deletions(-)
>
> diff --git a/tcg/sparc/tcg-target.h b/tcg/sparc/tcg-target.h
> index c050763049..8655acdbe5 100644
> --- a/tcg/sparc/tcg-target.h
> +++ b/tcg/sparc/tcg-target.h
> @@ -25,8 +25,6 @@
> #ifndef SPARC_TCG_TARGET_H
> #define SPARC_TCG_TARGET_H
>
> -#define TCG_TARGET_REG_BITS 64
Why do we delete this?
> diff --git a/tcg/sparc/tcg-target.c.inc b/tcg/sparc/tcg-target.c.inc
> index 72d9552fd0..097bcfcd12 100644
> --- a/tcg/sparc/tcg-target.c.inc
> +++ b/tcg/sparc/tcg-target.c.inc
> @@ -22,6 +22,11 @@
> * THE SOFTWARE.
> */
>
> +/* We only support generating code for 64-bit mode. */
> +#ifndef __arch64__
> +#error "unsupported code generation mode"
We might as well be more specific:
"no support for generating code for 32-bit SPARC"
(though I guess that configure ought in theory to prevent us getting here
in that situation ?)
Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2022-10-30 15:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 6:24 [PATCH 0/3] tcg/sparc: Remove support for sparc32plus Richard Henderson
2022-10-17 6:24 ` [PATCH 1/3] " Richard Henderson
2022-10-28 10:39 ` Philippe Mathieu-Daudé
2022-10-30 15:45 ` Peter Maydell [this message]
2022-10-30 17:21 ` Philippe Mathieu-Daudé
2022-10-30 23:22 ` Richard Henderson
2022-10-31 10:47 ` Peter Maydell
2022-10-30 23:24 ` Richard Henderson
2022-10-17 6:24 ` [PATCH 2/3] tcg/sparc64: Rename from tcg/sparc Richard Henderson
2022-10-28 10:40 ` Philippe Mathieu-Daudé
2022-10-30 15:50 ` Peter Maydell
2022-10-17 6:24 ` [PATCH 3/3] tcg/sparc64: Remove sparc32plus constraints Richard Henderson
2022-10-30 15:38 ` Peter Maydell
2022-10-24 23:03 ` [PATCH 0/3] tcg/sparc: Remove support for sparc32plus Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-7q2fat9grNuTVcvzozTiCUBaPSSwqHLe02Dos7zFing@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).