From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D271C00140 for ; Fri, 5 Aug 2022 08:57:04 +0000 (UTC) Received: from localhost ([::1]:56102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJt8h-000878-9H for qemu-devel@archiver.kernel.org; Fri, 05 Aug 2022 04:57:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJt5B-0004Ah-Di for qemu-devel@nongnu.org; Fri, 05 Aug 2022 04:53:26 -0400 Received: from mail-yb1-xb2d.google.com ([2607:f8b0:4864:20::b2d]:43756) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJt58-0002Ui-Fr for qemu-devel@nongnu.org; Fri, 05 Aug 2022 04:53:24 -0400 Received: by mail-yb1-xb2d.google.com with SMTP id o15so2809303yba.10 for ; Fri, 05 Aug 2022 01:53:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=PifjoE0qzd+7B0DfCHD1AeSrooxwSqkKnVvCY1z593o=; b=cmZ3tA8xMRMsSTRI2Y3KMs9gREi7udcgehR8TFLAWPoYNsW+KwRbj24Wwz2MfC0F6Y 8TAL+XW/KNm76xs+sq1Z/wrqVzHGh0r78bOjkN/7RpE6T5DfGQ3YOGB9R8mp2hOAUzu6 Tj1BhfxjxnMq/LL6t+yZ028etWoovU4WU+9yLtjx6EyTEghvAVmWjEPcS5xX42bX/CZ/ AVPgq5LKXlUo+J7SKMEZAkEF/CLv8JexjFSRv/mjl1HeeauLlzJgMVVcgxy3mMAk3hUI 2PvMwIo8CdlKsixld1CrTIu3HQhmu0gUsVtv9iAB1AanqDFNvMrhvu6/u4anhSoqxdPC 5q2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=PifjoE0qzd+7B0DfCHD1AeSrooxwSqkKnVvCY1z593o=; b=bHlgYcpxfq+j/eVni7zWAXkgVDq6rYPR8wsSH04nuvHisoWFqYS8vsqh2vqnos2ORQ kCrSYDI8agGZ77y/bMVupd1bhNoga1yT/tRWhxN0zmDvTJtgK4naF2Ye9OldP1YwU7P4 Cj/dyPq5Q4vmBrS6m1elE/R7tRlg4ovQq+0GRVQgkgc0W/EdM7PePTxQKL547DErLaO9 K4WZBsAx7V5LTqu/ynwuC0KdfS9qxqDJCNbu7PdFtqnhra67qlUYVa6O432DM4rL1iiB kCiB6V+qn3oCIQ/UNwPPYnTImBBtYjvgG17k65Z+rXe9vBWoT7rv1E93yRZC+leWgiFP 2Xcw== X-Gm-Message-State: ACgBeo3MySiE7vjV4HijyvbJ7aO7c4v/+0fsQF0aQlQ4NuSejCtoE0AV mCgCduWXEy7lDe/1n/tY3JRX4u32UMFOLhLXdWqTYw== X-Google-Smtp-Source: AA6agR6yn+W0DGc3Hx3x5Ly3TOtKjAJ8UH1VF1CfXGVnWKGX0cN100mHJfAzC/VdXiVc4NEIUREgbv3oBtfoxBp1s60= X-Received: by 2002:a25:d617:0:b0:671:79bd:69bf with SMTP id n23-20020a25d617000000b0067179bd69bfmr4565492ybg.85.1659689601249; Fri, 05 Aug 2022 01:53:21 -0700 (PDT) MIME-Version: 1.0 References: <20220802080948.37426-1-chen.zhang@intel.com> In-Reply-To: From: Peter Maydell Date: Fri, 5 Aug 2022 09:52:40 +0100 Message-ID: Subject: Re: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity. To: "Zhang, Chen" Cc: Jason Wang , Li Zhijian , qemu-dev Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::b2d; envelope-from=peter.maydell@linaro.org; helo=mail-yb1-xb2d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 5 Aug 2022 at 06:56, Zhang, Chen wrote: > > > > > -----Original Message----- > > From: Jason Wang > > I wonder under which case we can see data == NULL? > > > > AFAIK, data is either dup via packet_new() or assigned to a pointer to the buf > > in packet_new_nocopy(). > > Yes, you are right. I just checked it for hint of bugs. > Do you think no need to do it? If you think it is a "should never happen unless QEMU is buggy" case, then assert(data). thanks -- PMM