From: Peter Maydell <peter.maydell@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-devel@nongnu.org, philmd@linaro.org,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: Re: [PATCH 1/2] hw: Move declaration of IRQState to header and add init function
Date: Mon, 1 Jul 2024 13:52:16 +0100 [thread overview]
Message-ID: <CAFEAcA-9W++mV4B2AUBN5O8ZazPYdO6BhCg7PpfKXbW=frzneg@mail.gmail.com> (raw)
In-Reply-To: <e3ffd0f6ef8845d0f7247c9b6ff33f7ee8b432cf.1719690591.git.balaton@eik.bme.hu>
On Sat, 29 Jun 2024 at 21:01, BALATON Zoltan <balaton@eik.bme.hu> wrote:
>
> To allow embedding a qemu_irq in a struct move its definition to the
> header and add a function to init it in place without allocating it.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Yes, I think this makes sense, and I'm not quite sure
why we don't support it already (probably just historical
inertia -- the qemu_irq APIs were written before QOM
and when the whole design was oriented around an
"allocate and return a pointer" style rather than
allowing for embedding structs).
-- PMM
next prev parent reply other threads:[~2024-07-01 12:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-29 20:01 [PATCH 0/2] Solve vt82c686 qemu_irq leak BALATON Zoltan
2024-06-29 20:01 ` [PATCH 1/2] hw: Move declaration of IRQState to header and add init function BALATON Zoltan
2024-07-01 12:52 ` Peter Maydell [this message]
2024-06-29 20:01 ` [PATCH 2/2] hw/isa/vt82c686.c: Embed i8259 irq in device state instead of allocating BALATON Zoltan
2024-07-01 12:58 ` Peter Maydell
2024-07-01 18:27 ` BALATON Zoltan
2024-07-01 21:13 ` Mark Cave-Ayland
2024-07-02 18:42 ` Bernhard Beschow
2024-07-02 21:17 ` Bernhard Beschow
2024-07-03 0:09 ` BALATON Zoltan
2024-07-03 7:15 ` Bernhard Beschow
2024-07-03 11:13 ` BALATON Zoltan
2024-07-04 21:06 ` Bernhard Beschow
2024-07-02 18:44 ` Bernhard Beschow
2024-09-10 7:10 ` [PATCH 0/2] Solve vt82c686 qemu_irq leak Michael S. Tsirkin
2024-09-13 13:00 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-9W++mV4B2AUBN5O8ZazPYdO6BhCg7PpfKXbW=frzneg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=akihiko.odaki@daynix.com \
--cc=balaton@eik.bme.hu \
--cc=jiaxun.yang@flygoat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).