qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Igor Mammedov <imammedo@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region
Date: Mon, 3 Aug 2015 10:48:15 +0100	[thread overview]
Message-ID: <CAFEAcA-9Yp7uSgDWE1rzPn_KFsxeJSiZQo4=Xt13aFfYTHTpdQ@mail.gmail.com> (raw)
In-Reply-To: <00be01d0cdc3$bb2e87d0$318b9770$@samsung.com>

On 3 August 2015 at 09:09, Pavel Fedin <p.fedin@samsung.com> wrote:
>  Hi!
>
>> What I thought you meant was that a non-LPAE kernel didn't
>> work at all if we told it about the high-MMIO window (which
>> would mean we'd need to *not* put that in the dtb if we
>> wanted to avoid breaking non-LPAE guests that didn't care
>> about the other window.)
>
>  Current generic PCI driver is not so smart. It simply tries to map all resources using devm_request_resource() in a loop. If a single call fails, the driver thinks that it cannot work and fails. It does not try to ignore inaccessible regions.

Then this is a kernel bug and the kernel should be fixed.

>> >  The behavior which i explained above causes boot problems if our
>> > configuration assumes that we boot off emulated PCI device. Because
>> > PCI controller becomes unusable.
>>
>> ...which is what you're saying here.
>>
>> Which is it?
>
>  I don't understand this last question...

I was confused about whether what happened was
(a) the high region is just ignored
(b) the presence of the high region in the device tree blob causes
things which previously worked to stop working

It sounds like the answer is (b).

>  In order to keep this guest working, we need a possibility to
> disable the new MMIO region in qemu. At least to omit it from the
> device tree.

Yes, this is the workaround, which it sounds like we need.

thanks
-- PMM

  reply	other threads:[~2015-08-03  9:48 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 11:09 [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region Pavel Fedin
2015-07-27 13:26 ` Igor Mammedov
2015-07-27 14:36   ` Pavel Fedin
2015-07-27 15:18     ` Michael S. Tsirkin
2015-07-27 15:51       ` Peter Maydell
2015-07-29  8:58   ` Pavel Fedin
2015-07-29  9:03     ` Peter Maydell
2015-07-29  9:45       ` Pavel Fedin
2015-07-29  9:56         ` Peter Maydell
2015-07-29 11:16           ` Pavel Fedin
2015-07-29 11:45             ` Peter Maydell
2015-07-29 14:01               ` Pavel Fedin
2015-08-03  7:03               ` Pavel Fedin
2015-08-03  7:56                 ` Peter Maydell
2015-08-03  8:09                   ` Pavel Fedin
2015-08-03  9:48                     ` Peter Maydell [this message]
2015-08-03 10:20                       ` Pavel Fedin
2015-08-03 20:17                         ` Alexander Graf
2015-07-29  9:32     ` Igor Mammedov
2015-07-29 10:03       ` Pavel Fedin
2015-07-29 10:21         ` Peter Maydell
2015-07-29 12:05         ` Igor Mammedov
2015-07-29 12:13           ` Pavel Fedin
2015-07-29 12:35           ` Peter Maydell
2015-07-29  9:10 ` Igor Mammedov
2015-07-29  9:48   ` Pavel Fedin
2015-07-29 11:59     ` Igor Mammedov
2015-07-29 12:02       ` Pavel Fedin
2015-07-29 13:24         ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA-9Yp7uSgDWE1rzPn_KFsxeJSiZQo4=Xt13aFfYTHTpdQ@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=agraf@suse.de \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=p.fedin@samsung.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).