From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH for-5.0] dump: Fix writing of ELF section
Date: Sat, 4 Apr 2020 10:07:33 +0100 [thread overview]
Message-ID: <CAFEAcA-9zHCHjyJ58sjzHkNVf=GQ7_HyLyQpiOLYbr55T-DZ1Q@mail.gmail.com> (raw)
In-Reply-To: <63099477-98e6-8c16-1c8c-a9a617062143@redhat.com>
On Fri, 3 Apr 2020 at 21:55, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 3/24/20 6:36 PM, Peter Maydell wrote:
> > In write_elf_section() we set the 'shdr' pointer to point to local
> > structures shdr32 or shdr64, which we fill in to be written out to
> > the ELF dump. Unfortunately the address we pass to fd_write_vmcore()
> > has a spurious '&' operator, so instead of writing out the section
> > header we write out the literal pointer value followed by whatever is
> > on the stack after the 'shdr' local variable.
>
> How did you notice this? While reviewing around?
Coverity, but I forgot to quote the CID in the commit message.
-- PMM
next prev parent reply other threads:[~2020-04-04 9:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 17:36 [PATCH for-5.0] dump: Fix writing of ELF section Peter Maydell
2020-03-24 17:38 ` Peter Maydell
2020-03-24 17:49 ` Marc-André Lureau
2020-04-03 18:26 ` Peter Maydell
2020-04-03 20:55 ` Philippe Mathieu-Daudé
2020-04-04 9:07 ` Peter Maydell [this message]
2020-04-06 10:01 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-9zHCHjyJ58sjzHkNVf=GQ7_HyLyQpiOLYbr55T-DZ1Q@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).