From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5E38C2BA16 for ; Sat, 4 Apr 2020 09:08:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C0C9206C3 for ; Sat, 4 Apr 2020 09:08:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XO+eg7Wh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C0C9206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKemt-00086Q-L7 for qemu-devel@archiver.kernel.org; Sat, 04 Apr 2020 05:08:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51904) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKemJ-0007hD-8A for qemu-devel@nongnu.org; Sat, 04 Apr 2020 05:07:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKemH-00089U-SC for qemu-devel@nongnu.org; Sat, 04 Apr 2020 05:07:46 -0400 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]:40742) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jKemH-000895-Jp for qemu-devel@nongnu.org; Sat, 04 Apr 2020 05:07:45 -0400 Received: by mail-oi1-x241.google.com with SMTP id y71so8461868oia.7 for ; Sat, 04 Apr 2020 02:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8g0lmOr9Oz5b+wZDZoTqLY0iLXCNRrLHsVWoWCaNYTI=; b=XO+eg7Wh3AaZIQBqc21WSIxVuorW/HIr5SvmC5R4qrbUmZYe9d5ArqPsuz74bxV8Bq crhmrWeQpp2tO4S3OcOVcyq4p/yjDWXXScJ8xRwnVuEptVBILq/seANllic31vypGJgf 0zSk65ibn7S+5YJFvcmDpFljRlJfo3smk0EoUrRCw2QnNKOcBf+c7x09cFnq3JtUIh8a sTUkC8UoJ52MkTAH9ALQWXiRiJ/2tYhY3/0hNDzA6kqbq1rnwFSpxkVvVHq525ljAhor JL7r2gXbVavhvYSB3H6IC0yVpeXbfnX012HnONW49Jm2ovpRLLY3MYn0k0cPq65CjJN2 IGZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8g0lmOr9Oz5b+wZDZoTqLY0iLXCNRrLHsVWoWCaNYTI=; b=Vd5q/KR+/YvMbl0XoS5T+FMbB86B/FeVT+KxfXh3Gb4f9BHIy2sLwJ8J7MjVUTjxnN /DG3XEdFrIUTUoSlxMTbjJVJTO/6r4vVNoROSTokkD62/f8rAL71lkqjk8fFESBOz0hs Avc5r2V3vWHLirW0N0wYaTtsbZSZS0qX30VxGmBaRmVyfeqgHiNcuk0pBDVTHv2aCjeZ ZgoNvIM5Vs1HLyFZdyUsaSirbGg0FePBsNzKqGY7Z4xY4DNBw4iH0bm+BsElv1VhAc7G EuhAJ68/bGAGvQ71341keDw7eSUXbprUoGzXqsG4W91oNanFn2CeG3oPYIsi+9SfZU8F TdkA== X-Gm-Message-State: AGi0PuZt+2l4h5cCINpQL/1UxT3JqWG20SwlQkNaurrNIk2btLRFOw7+ cxTgkOBcv8uiSLJBJz3tZsXxm67A5CpQWAxhhVjjjA== X-Google-Smtp-Source: APiQypJ+4J4Ya47dI+BPjwuVQgzW+6SzETlIRIW0PiSfeygmLuU+JCwsHfPPACUGsLn2NKs8wsSx6l0Fr9sOVEJraek= X-Received: by 2002:a05:6808:8cb:: with SMTP id k11mr5710715oij.48.1585991264449; Sat, 04 Apr 2020 02:07:44 -0700 (PDT) MIME-Version: 1.0 References: <20200324173630.12221-1-peter.maydell@linaro.org> <63099477-98e6-8c16-1c8c-a9a617062143@redhat.com> In-Reply-To: <63099477-98e6-8c16-1c8c-a9a617062143@redhat.com> From: Peter Maydell Date: Sat, 4 Apr 2020 10:07:33 +0100 Message-ID: Subject: Re: [PATCH for-5.0] dump: Fix writing of ELF section To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::241 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 3 Apr 2020 at 21:55, Philippe Mathieu-Daud=C3=A9 wrote: > > On 3/24/20 6:36 PM, Peter Maydell wrote: > > In write_elf_section() we set the 'shdr' pointer to point to local > > structures shdr32 or shdr64, which we fill in to be written out to > > the ELF dump. Unfortunately the address we pass to fd_write_vmcore() > > has a spurious '&' operator, so instead of writing out the section > > header we write out the literal pointer value followed by whatever is > > on the stack after the 'shdr' local variable. > > How did you notice this? While reviewing around? Coverity, but I forgot to quote the CID in the commit message. -- PMM