From: Peter Maydell <peter.maydell@linaro.org>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Peter Crosthwaite <crosthwaitepeter@gmail.com>,
Richard Henderson <rth@twiddle.net>,
QEMU Developers <qemu-devel@nongnu.org>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] configure: Unify arm and aarch64 disas configury
Date: Tue, 26 May 2015 09:24:22 +0100 [thread overview]
Message-ID: <CAFEAcA-=j_fJGhEE0P4CBb4Axa8tiFGbaYk_zntRYn7-sOwozA@mail.gmail.com> (raw)
In-Reply-To: <CAEgOgz7FKk0S=o9gC6AeW1tatmZyth53u8h28JvWtkb8ayueaw@mail.gmail.com>
On 26 May 2015 at 09:01, Peter Crosthwaite <peter.crosthwaite@xilinx.com> wrote:
> On Tue, May 26, 2015 at 12:18 AM, Peter Maydell
> <peter.maydell@linaro.org> wrote:
>> On 26 May 2015 at 06:49, Peter Crosthwaite <crosthwaitepeter@gmail.com> wrote:
>>> From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
>>>
>>> The "arm" variant for this case already contains everything needed
>>> for aarch64. As aarch64 already uses arm as a base architecture, it
>>> will already have the CONFIG_ARM_DIS defined meaning no functional
>>> change. So just make the configure code simpler.
>>
>> I'm wondering why we needed to put the A64 disassembler into
>> the "arm" variant at all...
>>
>
> That probably works too. I'm trying to get rid of the dup. respin it?
I think it would look more like the other entries in the case statement,
so worth trying. Maybe we'll find out why it's done this way :-)
-- PMM
next prev parent reply other threads:[~2015-05-26 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 5:49 [Qemu-devel] [PATCH] configure: Unify arm and aarch64 disas configury Peter Crosthwaite
2015-05-26 7:18 ` Peter Maydell
2015-05-26 8:01 ` Peter Crosthwaite
2015-05-26 8:24 ` Peter Maydell [this message]
2015-06-07 8:49 ` Peter Crosthwaite
2015-06-07 10:51 ` Peter Maydell
2015-06-07 19:19 ` Peter Crosthwaite
2015-06-08 7:52 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-=j_fJGhEE0P4CBb4Axa8tiFGbaYk_zntRYn7-sOwozA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=crosthwaite.peter@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).