From: Peter Maydell <peter.maydell@linaro.org>
To: Juan Quintela <quintela@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 004/124] savevm: Remove all the unneded version_minimum_id_old (arm)
Date: Thu, 8 May 2014 13:01:41 +0100 [thread overview]
Message-ID: <CAFEAcA-A8OpAQZJG9ufF9jSwSLs1Oxz8R9ca5WOG5+6GRPfdmw@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA-4BAB_G3+rBp1u4CtZCCV0=b2xeuxQTc2yDxNxSo=8Mw@mail.gmail.com>
On 21 April 2014 17:18, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 21 April 2014 15:39, Juan Quintela <quintela@redhat.com> wrote:
>> After previous Peter patch, they are redundant. This way we don't asign them
>> except when needed. Once there, there were lots of case where the ".fields"
>> indentation was wrong:
>>
>> .fields = (VMStateField []) {
>> and
>> .fields = (VMStateField []) {
>>
>> Change all the combinations to:
>>
>> .fields = (VMStateField[]){
>>
>> The biggest problem (appart of aesthetics) was that checkpatch complained
>> when we copy&pasted the code from one place to another.
>>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> I'll hold this to apply to target-arm.next when you've got the dependent
> patch into master.
The dependent patch is now in master so I'm going to include this
in the target-arm queue (with the various typos Eric pointed out
in the commit message fixed).
thanks
-- PMM
next prev parent reply other threads:[~2014-05-08 12:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1398091304-10677-1-git-send-email-quintela@redhat.com>
[not found] ` <1398091304-10677-10-git-send-email-quintela@redhat.com>
2014-05-06 8:12 ` [Qemu-devel] [PATCH 009/124] vmstate: Refactor opening of files Amit Shah
[not found] ` <1398091304-10677-5-git-send-email-quintela@redhat.com>
[not found] ` <CAFEAcA-4BAB_G3+rBp1u4CtZCCV0=b2xeuxQTc2yDxNxSo=8Mw@mail.gmail.com>
2014-05-08 12:01 ` Peter Maydell [this message]
2014-05-08 17:40 ` [Qemu-devel] [PATCH 004/124] savevm: Remove all the unneded version_minimum_id_old (arm) Juan Quintela
2014-05-08 18:06 ` Peter Maydell
[not found] ` <1398091304-10677-3-git-send-email-quintela@redhat.com>
2014-05-12 11:00 ` [Qemu-devel] [PATCH 002/124] savevm: Remove all the unneded version_minimum_id_old (usb) Juan Quintela
2014-05-12 13:31 ` Gerd Hoffmann
[not found] ` <1398091304-10677-4-git-send-email-quintela@redhat.com>
2014-06-04 11:35 ` [Qemu-devel] [PATCH 003/124] savevm: Remove all the unneded version_minimum_id_old (ppc) Juan Quintela
2014-06-04 14:44 ` Alexey Kardashevskiy
[not found] ` <1398091304-10677-6-git-send-email-quintela@redhat.com>
2014-06-04 11:36 ` [Qemu-devel] [PATCH 005/124] savevm: Remove all the unneded version_minimum_id_old (x86) Juan Quintela
2014-06-04 14:44 ` Alexey Kardashevskiy
2014-06-05 6:12 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-A8OpAQZJG9ufF9jSwSLs1Oxz8R9ca5WOG5+6GRPfdmw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).