From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34072)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WiN1c-0004kg-Fu
	for qemu-devel@nongnu.org; Thu, 08 May 2014 08:02:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WiN1X-00065L-AF
	for qemu-devel@nongnu.org; Thu, 08 May 2014 08:02:08 -0400
Received: from mail-lb0-f173.google.com ([209.85.217.173]:45149)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WiN1X-00065C-42
	for qemu-devel@nongnu.org; Thu, 08 May 2014 08:02:03 -0400
Received: by mail-lb0-f173.google.com with SMTP id 10so3402838lbg.32
	for <qemu-devel@nongnu.org>; Thu, 08 May 2014 05:02:02 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAFEAcA-4BAB_G3+rBp1u4CtZCCV0=b2xeuxQTc2yDxNxSo=8Mw@mail.gmail.com>
References: <1398091304-10677-1-git-send-email-quintela@redhat.com>
	<1398091304-10677-5-git-send-email-quintela@redhat.com>
	<CAFEAcA-4BAB_G3+rBp1u4CtZCCV0=b2xeuxQTc2yDxNxSo=8Mw@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 8 May 2014 13:01:41 +0100
Message-ID: <CAFEAcA-A8OpAQZJG9ufF9jSwSLs1Oxz8R9ca5WOG5+6GRPfdmw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 004/124] savevm: Remove all the unneded
 version_minimum_id_old (arm)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 21 April 2014 17:18, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 21 April 2014 15:39, Juan Quintela <quintela@redhat.com> wrote:
>> After previous Peter patch, they are redundant.  This way we don't asign them
>> except when needed.  Once there, there were lots of case where the ".fields"
>> indentation was wrong:
>>
>>      .fields = (VMStateField []) {
>> and
>>      .fields =      (VMStateField []) {
>>
>> Change all the combinations to:
>>
>>      .fields = (VMStateField[]){
>>
>> The biggest problem (appart of aesthetics) was that checkpatch complained
>> when we copy&pasted the code from one place to another.
>>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> I'll hold this to apply to target-arm.next when you've got the dependent
> patch into master.

The dependent patch is now in master so I'm going to include this
in the target-arm queue (with the various typos Eric pointed out
in the commit message fixed).

thanks
-- PMM