From: Peter Maydell <peter.maydell@linaro.org>
To: Petar Jovanovic <Petar.Jovanovic@imgtec.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Riku Voipio <riku.voipio@linaro.org>,
Michael Tokarev <mjt@tls.msk.ru>,
Petar Jovanovic <petar.jovanovic@rt-rk.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: pass correct parameter to do_shmctl()
Date: Mon, 21 Oct 2013 14:26:44 +0100 [thread overview]
Message-ID: <CAFEAcA-ASmyrbDBCYaMPMUB-yKHAZ_QrYDevsyZEMYqGdG7OBQ@mail.gmail.com> (raw)
In-Reply-To: <56EA75BA695AE044ACFB41322F6D2BF44CCA356C@BADAG01.ba.imgtec.org>
On 21 October 2013 11:49, Petar Jovanovic <Petar.Jovanovic@imgtec.com> wrote:
> From: Michael Tokarev [mjt@tls.msk.ru]
>> Shouldn't the two patches be applied together and be routed via some
>> other, "non-trivial" tree instead?
>
> This is what I originally did, but Peter suggested to separate it in two patches.
> Dividing that patch into two separate patches made this one trivial.
I meant, "divide this one patch into two patches and post them as
a single patch series [ie a cover letter with patches labelled 1/2 and
2/2, with the correct threading]". This is the standard way to submit
changes which are best split into multiple patches/commits for
ease of review but which combine to form a single feature/bugfix.
These patches should all go via linux-user, yes.
thanks
-- PMM
next prev parent reply other threads:[~2013-10-21 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 13:03 [Qemu-devel] [PATCH] linux-user: pass correct parameter to do_shmctl() Petar Jovanovic
2013-10-11 19:10 ` Peter Maydell
2013-10-11 20:44 ` Petar Jovanovic
2013-10-21 8:45 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-10-21 10:49 ` Petar Jovanovic
2013-10-21 13:26 ` Peter Maydell [this message]
2013-10-21 14:07 ` Petar Jovanovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-ASmyrbDBCYaMPMUB-yKHAZ_QrYDevsyZEMYqGdG7OBQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=Petar.Jovanovic@imgtec.com \
--cc=mjt@tls.msk.ru \
--cc=petar.jovanovic@rt-rk.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=riku.voipio@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).