From: Peter Maydell <peter.maydell@linaro.org>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] kvm: add set_one_reg/get_one_reg
Date: Wed, 18 Sep 2013 17:15:47 +0900 [thread overview]
Message-ID: <CAFEAcA-B5MrPLVzqgon654oycfwoenLfdNP=FpSiWNuev2Wobg@mail.gmail.com> (raw)
In-Reply-To: <52395F88.7000203@ozlabs.ru>
On 18 September 2013 17:08, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> On 09/18/2013 05:59 PM, Peter Maydell wrote:
> It would be awesome if you just gave me any really good example of what you
> expect from such a comment as kvm-all.c does not have any whatsoever. And
> pci.c does not. And exec.c does not. But I am sure there is some as
> it cannot possibly be me who starts making such comments in qemu. Thanks.
Yes, we have a lot of preexisting undocumented functions. It's
very common in QEMU for existing code not to be up to preferred
standards; you can't use current code as a yardstick for "good enough
to pass code review".
The example I usually crib from for formatting is the extract/deposit
APIs in include/qemu/bitops.h. include/exec/memory.h is also well
documented.
-- PMM
prev parent reply other threads:[~2013-09-18 8:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 4:21 [Qemu-devel] [PATCH] kvm: add set_one_reg/get_one_reg Alexey Kardashevskiy
2013-09-18 7:14 ` Peter Maydell
2013-09-18 7:46 ` Alexey Kardashevskiy
2013-09-18 7:59 ` Peter Maydell
2013-09-18 8:08 ` Alexey Kardashevskiy
2013-09-18 8:15 ` Paolo Bonzini
2013-09-18 8:15 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-B5MrPLVzqgon654oycfwoenLfdNP=FpSiWNuev2Wobg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).