From: Peter Maydell <peter.maydell@linaro.org>
To: Yuquan Wang <wangyuquan1236@phytium.com.cn>
Cc: rad@semihalf.com, pbonzini@redhat.com,
marcin.juszkiewicz@linaro.org, quic_llindhol@quicinc.com,
chenbaozi@phytium.com.cn, qemu-arm@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [PATCH v4 1/1] hw/arm/sbsa-ref: use XHCI to replace EHCI
Date: Mon, 19 Jun 2023 13:47:16 +0100 [thread overview]
Message-ID: <CAFEAcA-B6Pbc2KyTVP9hheGfEecfTbwu-zi7_9EmjJH5opbiYg@mail.gmail.com> (raw)
In-Reply-To: <20230607023314.192439-2-wangyuquan1236@phytium.com.cn>
On Wed, 7 Jun 2023 at 03:34, Yuquan Wang <wangyuquan1236@phytium.com.cn> wrote:
>
> The current sbsa-ref cannot use EHCI controller which is only
> able to do 32-bit DMA, since sbsa-ref doesn't have RAM below 4GB.
> Hence, this uses system bus XHCI to provide a usb controller with
> 64-bit DMA capablity instead of EHCI.
"capability"
> Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn>
The change itself looks good. We could probably mention in
the commit message that existing firmware/kernel images
still work (with no USB support) with this change.
Is this the sort of change that we should increase the
machine-version-minor for ? The comment says "updated
when features are added that don't break fw compatibility"
and this sounds like one of those.
Leif, do you think we should bump the minor version here?
thanks
-- PMM
next prev parent reply other threads:[~2023-06-19 12:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 2:33 [PATCH v4 0/1] use XHCI to replace EHCI Yuquan Wang
2023-06-07 2:33 ` [PATCH v4 1/1] hw/arm/sbsa-ref: " Yuquan Wang
2023-06-07 7:25 ` Chen Baozi
2023-06-19 10:28 ` Peter Maydell
2023-06-19 15:24 ` Chen Baozi
2023-06-14 8:12 ` Marcin Juszkiewicz
2023-06-19 12:47 ` Peter Maydell [this message]
2023-06-20 17:24 ` Leif Lindholm
2023-06-21 3:46 ` Yuquan Wang
2023-06-21 7:11 ` Marcin Juszkiewicz
2023-06-07 3:21 ` [PATCH v4 0/1] " wangyuquan1236
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-B6Pbc2KyTVP9hheGfEecfTbwu-zi7_9EmjJH5opbiYg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=chenbaozi@phytium.com.cn \
--cc=marcin.juszkiewicz@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
--cc=wangyuquan1236@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).