qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Zhang Wen <zhw2101024@gmail.com>,
	qemu-trivial@nongnu.org, pbonzini@redhat.com,
	 marcandre.lureau@redhat.com, berrange@redhat.com,
	thuth@redhat.com,  philmd@linaro.org, qemu-devel@nongnu.org
Subject: Re: building qemu on a system with libxkbcommon installed but not xkeyboard-config produces an core dump
Date: Thu, 1 Feb 2024 12:57:15 +0000	[thread overview]
Message-ID: <CAFEAcA-C-pGGYY1bfE0ZatZP-imGmq=4-579TEnEZWFLeLxZLQ@mail.gmail.com> (raw)
In-Reply-To: <e441b771-0a08-4f2c-b7a7-f6fdd787bc1c@tls.msk.ru>

On Thu, 1 Feb 2024 at 12:50, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> 01.02.2024 15:11, Michael Tokarev wrote:
> > 31.01.2024 11:13, Zhang Wen:
> >> With this patch, qemu requires keyboard-config when libxkbcommon is found on the system. So if the qemu is configured when libxkbcommon is installed
> >> but not keyboard-config, the configure stage will produce an error message, thus avoid coredump in the build stage.
> >
> > I'm not sure what you're talking about.  What *is* keyboard-config anyway?
> >
> > On a debian system there's no such thing.  There's keyboard-configuration
> > package but it has nothing to do with that.  It looks like if we apply
> > such patch, it will be impossible to build qemu on debian.
>
> Aha, I found it.  On debian it is /usr/share/pkgconfig/keyboard-config.pc,
> which is a part of xkb-data package.  And libxkbcommon Depends on xkb-data.
> It looks like the distribution here is wrong, there should be no libxkbcommon
> without xkb-data which includes keyboard-config.

Are we talking about "keyboard-config" or "xkeyboard-config" here?
The commit message says "keyboard-config" but the patch itself
says "xkeyboard-config".

Zhang: it would be helpful if you could tell us which distro
you are building on where you see this problem.

thanks
-- PMM


  reply	other threads:[~2024-02-01 12:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31  8:13 building qemu on a system with libxkbcommon installed but not xkeyboard-config produces an core dump Zhang Wen
2024-02-01 12:11 ` Michael Tokarev
2024-02-01 12:49   ` Michael Tokarev
2024-02-01 12:57     ` Peter Maydell [this message]
2024-02-01 12:59       ` Michael Tokarev
2024-02-06  6:35       ` Zhang Wen
2024-02-06  7:08         ` Michael Tokarev
2024-02-06  7:50           ` Zhang Wen
2024-02-08  2:00             ` Zhang Wen
2024-02-08 11:52         ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA-C-pGGYY1bfE0ZatZP-imGmq=4-579TEnEZWFLeLxZLQ@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=zhw2101024@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).