qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Jean-Christophe DUBOIS <jcd@tribudubois.net>
Cc: peter.chubb@nicta.com.au, qemu-devel@nongnu.org, philipo@ok-labs.com
Subject: Re: [Qemu-devel] [PATCH] i.MX: implement a more correct version of EPIT timer.
Date: Wed, 10 Apr 2013 09:26:13 +0100	[thread overview]
Message-ID: <CAFEAcA-CF8vuR4ve-+93mkux+9RHKZe2U_gjvoerzA3FSM53qw@mail.gmail.com> (raw)
In-Reply-To: <1365546746-7867-1-git-send-email-jcd@tribudubois.net>

On 9 April 2013 23:32, Jean-Christophe DUBOIS <jcd@tribudubois.net> wrote:
> @@ -605,11 +735,13 @@ static const VMStateDescription vmstate_imx_timerp = {
>      .minimum_version_id_old = 1,
>      .fields      = (VMStateField[]) {
>          VMSTATE_UINT32(cr, IMXTimerPState),
> +        VMSTATE_UINT32(sr, IMXTimerPState),
>          VMSTATE_UINT32(lr, IMXTimerPState),
>          VMSTATE_UINT32(cmp, IMXTimerPState),
> +        VMSTATE_UINT32(cnt, IMXTimerPState),
>          VMSTATE_UINT32(freq, IMXTimerPState),
> -        VMSTATE_INT32(int_level, IMXTimerPState),
> -        VMSTATE_PTIMER(timer, IMXTimerPState),
> +        VMSTATE_PTIMER(timer_reload, IMXTimerPState),
> +        VMSTATE_PTIMER(timer_cmp, IMXTimerPState),
>          VMSTATE_END_OF_LIST()
>      }
>  };

If you're adding/changing vmstate fields like this then you
need to increment all the version id fields too. Otherwise
cross-version migration will break oddly (rather than failing
cleanly).

thanks
-- PMM

  parent reply	other threads:[~2013-04-10  8:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-09 22:32 [Qemu-devel] [PATCH] i.MX: implement a more correct version of EPIT timer Jean-Christophe DUBOIS
2013-04-09 23:27 ` Peter Chubb
2013-04-10  6:12   ` Jean-Christophe DUBOIS
2013-04-10  8:26 ` Peter Maydell [this message]
2013-04-10 19:55   ` Jean-Christophe DUBOIS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA-CF8vuR4ve-+93mkux+9RHKZe2U_gjvoerzA3FSM53qw@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=jcd@tribudubois.net \
    --cc=peter.chubb@nicta.com.au \
    --cc=philipo@ok-labs.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).