From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Thomas Huth <huth@tuxfamily.org>,
Magnus Damm <magnus.damm@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Michael Walle <michael@walle.cc>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>
Subject: Re: [PATCH 5/8] hw/timer/altera_timer.c: Switch to transaction-based ptimer API
Date: Thu, 17 Oct 2019 17:10:40 +0100 [thread overview]
Message-ID: <CAFEAcA-CFGt3vXnrvtbXF-GOJmx=34GdbrhnNHyPnHAnguKtuw@mail.gmail.com> (raw)
In-Reply-To: <18066f84-ea56-20c3-6e43-58978f8569bb@redhat.com>
On Thu, 17 Oct 2019 at 17:09, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 10/17/19 3:29 PM, Peter Maydell wrote:
> > - t->bh = qemu_bh_new(timer_hit, t);
> > - t->ptimer = ptimer_init_with_bh(t->bh, PTIMER_POLICY_DEFAULT);
> > + t->ptimer = ptimer_init(timer_hit, t, PTIMER_POLICY_DEFAULT);
> > + ptimer_transaction_begin(t->ptimer);
> > ptimer_set_freq(t->ptimer, t->freq_hz);
> > + ptimer_transaction_commit(t->ptimer);
>
> This looks odd because timers are not running at this point (REALIZE),
> but if we don't protect it, ptimer_set_freq() will trigger the assertion.
Yep. The same pattern is used in several of the other ptimer
users where a fixed frequency or period is set immediately after
init.
thanks
-- PMM
next prev parent reply other threads:[~2019-10-17 17:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 13:28 [PATCH 0/8] Convert misc-arch devices to new ptimer API Peter Maydell
2019-10-17 13:28 ` [PATCH 1/8] hw/timer/puv3_ost.c: Switch to transaction-based " Peter Maydell
2019-10-17 14:26 ` Richard Henderson
2019-10-17 15:59 ` Philippe Mathieu-Daudé
2019-10-17 13:28 ` [PATCH 2/8] hw/timer/sh_timer: " Peter Maydell
2019-10-17 14:49 ` Richard Henderson
2019-10-17 16:01 ` Philippe Mathieu-Daudé
2019-10-17 13:29 ` [PATCH 3/8] hw/timer/lm32_timer: " Peter Maydell
2019-10-17 14:51 ` Richard Henderson
2019-10-17 16:10 ` Philippe Mathieu-Daudé
2019-10-17 13:29 ` [PATCH 4/8] hw/watchdog/milkymist-sysctl.c: " Peter Maydell
2019-10-17 14:52 ` Richard Henderson
2019-10-17 15:42 ` Philippe Mathieu-Daudé
2019-10-17 13:29 ` [PATCH 5/8] hw/timer/altera_timer.c: " Peter Maydell
2019-10-17 15:02 ` Richard Henderson
2019-10-17 16:09 ` Philippe Mathieu-Daudé
2019-10-17 16:10 ` Peter Maydell [this message]
2019-10-17 13:29 ` [PATCH 6/8] hw/watchdog/etraxfs_timer.c: " Peter Maydell
2019-10-17 15:06 ` Richard Henderson
2019-10-17 15:47 ` Philippe Mathieu-Daudé
2019-10-17 13:29 ` [PATCH 7/8] hw/m68k/mcf5206.c: " Peter Maydell
2019-10-17 15:07 ` Richard Henderson
2019-10-17 15:48 ` Philippe Mathieu-Daudé
2019-10-19 10:48 ` Thomas Huth
2019-10-19 11:10 ` Thomas Huth
2019-10-19 11:38 ` Thomas Huth
2019-10-17 13:29 ` [PATCH 8/8] hw/m68k/mcf5208.c: " Peter Maydell
2019-10-17 15:08 ` Richard Henderson
2019-10-17 15:49 ` Philippe Mathieu-Daudé
2019-10-19 10:52 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-CFGt3vXnrvtbXF-GOJmx=34GdbrhnNHyPnHAnguKtuw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=edgar.iglesias@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=huth@tuxfamily.org \
--cc=magnus.damm@gmail.com \
--cc=michael@walle.cc \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).