qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Sergey Fedorov <serge.fdrv@gmail.com>
Cc: qemu-arm@nongnu.org, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] target-arm: Update condexec before CP access check in AA32 translation
Date: Tue, 17 Nov 2015 13:31:01 +0000	[thread overview]
Message-ID: <CAFEAcA-CLEaRWimu2R-k9kbRvXUkfqMp4si4dai1B-DSrELWuQ@mail.gmail.com> (raw)
In-Reply-To: <564B0874.3050902@gmail.com>

On 17 November 2015 at 10:59, Sergey Fedorov <serge.fdrv@gmail.com> wrote:
> On 16.11.2015 22:34, Sergey Fedorov wrote:
>> Coprocessor access instructions are allowed inside IT block.
>> gen_helper_access_check_cp_reg() can raise an exceptions thus condexec
>> bits should be updated before.
>>
>> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
>> ---
>>  target-arm/translate.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/target-arm/translate.c b/target-arm/translate.c
>> index 4351854..f1f8129 100644
>> --- a/target-arm/translate.c
>> +++ b/target-arm/translate.c
>> @@ -7210,6 +7210,7 @@ static int disas_coproc_insn(DisasContext *s, uint32_t insn)
>>                  break;
>>              }
>>
>> +            gen_set_condexec(dc);
>
> Ah, there must be gen_set_condexec(s).

Yep. Are you going to resend?

thanks
-- PMM

  reply	other threads:[~2015-11-17 13:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-16 19:34 [Qemu-devel] [PATCH 0/2] target-arm: Missed gen_set_condexec() in AA32 translation Sergey Fedorov
2015-11-16 19:34 ` [Qemu-devel] [PATCH 1/2] target-arm: Update condexec before CP access check " Sergey Fedorov
2015-11-17 10:59   ` Sergey Fedorov
2015-11-17 13:31     ` Peter Maydell [this message]
2015-11-17 13:38       ` Sergey Fedorov
2015-11-16 19:34 ` [Qemu-devel] [PATCH 2/2] target-arm: Update condexec before arch BP " Sergey Fedorov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA-CLEaRWimu2R-k9kbRvXUkfqMp4si4dai1B-DSrELWuQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=serge.fdrv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).