From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrXCL-0004cd-9u for qemu-devel@nongnu.org; Wed, 18 Jul 2012 12:34:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrXCK-0001KX-65 for qemu-devel@nongnu.org; Wed, 18 Jul 2012 12:34:01 -0400 Received: from mail-bk0-f45.google.com ([209.85.214.45]:49807) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrXCJ-0001KK-W0 for qemu-devel@nongnu.org; Wed, 18 Jul 2012 12:34:00 -0400 Received: by bkcji1 with SMTP id ji1so1454293bkc.4 for ; Wed, 18 Jul 2012 09:33:58 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1342627957-31682-1-git-send-email-sw@weilnetz.de> References: <1342627957-31682-1-git-send-email-sw@weilnetz.de> Date: Wed, 18 Jul 2012 17:33:58 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] Use macro QEMU_PACKED for new packed structures List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On 18 July 2012 17:12, Stefan Weil wrote: > Since commit 541dc0d47f10973c241e9955afc2aefc96adec51, > some new packed structures were added without using QEMU_PACKED. > > QEMU_PACKED is needed for compilations with MinGW. > For other platforms nothing changes. > > The code was fixed using this command: > > git grep -la '__attribute__ ((packed))'|xargs perl -pi -e 's/__attribute__ \(\(packed\)\)/QEMU_PACKED/' There's one in tcg/tcg.c as well, which you missed because it doesn't have a space between the "__attribute__" and "((packed))". (There are also some in some of the tcg-target.c files, but those are cases of the packed attribute being applied to individual struct members rather than a whole struct, so I'm not entirely sure what we should do with those.) -- PMM