From: Peter Maydell <peter.maydell@linaro.org>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH target-arm v7 1/1] target-arm: Implements the ARM PMCCNTR register
Date: Fri, 21 Feb 2014 00:07:18 +0000 [thread overview]
Message-ID: <CAFEAcA-D4gM2cwRAtOLcQFJZ+7hpmXdb-Zaobp0QeRHuzqYZCA@mail.gmail.com> (raw)
In-Reply-To: <CAKmqyKNJPSaZ5+NWrDVsbafhUorTWu99wWJjvqea8EjP=K4DtA@mail.gmail.com>
On 20 February 2014 23:58, Alistair Francis <alistair.francis@xilinx.com> wrote:
> On Fri, Feb 21, 2014 at 1:44 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
>> This breaks compilation of the arm-linux-user target
>> (the qemu_clock_get_* functions are only available in
>> system mode). You probably want to do something similar
>> to how we handle the generic timers, where we #ifdef
>> everything out. (I don't think Linux gives user
>> space access to the perf monitor registers.)
> What do you think the functions should do when in user space? Should
> they just return 0?
Just don't define reginfo entries for them at all -- then we will
UNDEF because the lookup will return no result. This is what
the generic timer code does.
thanks
-- PMM
next prev parent reply other threads:[~2014-02-21 0:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 23:57 [Qemu-devel] [PATCH target-arm v7 1/1] target-arm: Implements the ARM PMCCNTR register Alistair Francis
2014-02-20 15:44 ` Peter Maydell
2014-02-20 23:58 ` Alistair Francis
2014-02-21 0:07 ` Peter Maydell [this message]
2014-02-21 0:52 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-D4gM2cwRAtOLcQFJZ+7hpmXdb-Zaobp0QeRHuzqYZCA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alistair.francis@xilinx.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).