From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGdea-0004fb-M9 for qemu-devel@nongnu.org; Thu, 20 Feb 2014 19:07:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGdeW-0000LV-9F for qemu-devel@nongnu.org; Thu, 20 Feb 2014 19:07:44 -0500 Received: from mail-lb0-f171.google.com ([209.85.217.171]:40809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGdeW-0000LP-2h for qemu-devel@nongnu.org; Thu, 20 Feb 2014 19:07:40 -0500 Received: by mail-lb0-f171.google.com with SMTP id c11so1843221lbj.16 for ; Thu, 20 Feb 2014 16:07:39 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <57a391d51a6430e74fad5b88316c504b9217c306.1392853953.git.alistair.francis@xilinx.com> From: Peter Maydell Date: Fri, 21 Feb 2014 00:07:18 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH target-arm v7 1/1] target-arm: Implements the ARM PMCCNTR register List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis Cc: Peter Crosthwaite , QEMU Developers On 20 February 2014 23:58, Alistair Francis wrote: > On Fri, Feb 21, 2014 at 1:44 AM, Peter Maydell wrote: >> This breaks compilation of the arm-linux-user target >> (the qemu_clock_get_* functions are only available in >> system mode). You probably want to do something similar >> to how we handle the generic timers, where we #ifdef >> everything out. (I don't think Linux gives user >> space access to the perf monitor registers.) > What do you think the functions should do when in user space? Should > they just return 0? Just don't define reginfo entries for them at all -- then we will UNDEF because the lookup will return no result. This is what the generic timer code does. thanks -- PMM