* [Qemu-devel] [PATCH v2] ui/cocoa: Include less of the generated modular QAPI headers
@ 2018-12-20 8:45 Markus Armbruster
2018-12-20 10:17 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Markus Armbruster @ 2018-12-20 8:45 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, r.bolshakov
Avoids pointless recompilation. Missed in commit 112ed241f5d.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
ui/cocoa.m | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index ecf12bfc2e..ddc058e76e 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -32,7 +32,8 @@
#include "ui/input.h"
#include "sysemu/sysemu.h"
#include "qapi/error.h"
-#include "qapi/qapi-commands.h"
+#include "qapi/qapi-commands-block.h"
+#include "qapi/qapi-commands-misc.h"
#include "sysemu/blockdev.h"
#include "qemu-version.h"
#include <Carbon/Carbon.h>
--
2.17.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v2] ui/cocoa: Include less of the generated modular QAPI headers
2018-12-20 8:45 [Qemu-devel] [PATCH v2] ui/cocoa: Include less of the generated modular QAPI headers Markus Armbruster
@ 2018-12-20 10:17 ` Philippe Mathieu-Daudé
2018-12-20 11:50 ` Roman Bolshakov
2019-01-08 14:53 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-12-20 10:17 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: peter.maydell, r.bolshakov
On 12/20/18 9:45 AM, Markus Armbruster wrote:
> Avoids pointless recompilation. Missed in commit 112ed241f5d.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> ui/cocoa.m | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index ecf12bfc2e..ddc058e76e 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -32,7 +32,8 @@
> #include "ui/input.h"
> #include "sysemu/sysemu.h"
> #include "qapi/error.h"
> -#include "qapi/qapi-commands.h"
> +#include "qapi/qapi-commands-block.h"
> +#include "qapi/qapi-commands-misc.h"
> #include "sysemu/blockdev.h"
> #include "qemu-version.h"
> #include <Carbon/Carbon.h>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v2] ui/cocoa: Include less of the generated modular QAPI headers
2018-12-20 8:45 [Qemu-devel] [PATCH v2] ui/cocoa: Include less of the generated modular QAPI headers Markus Armbruster
2018-12-20 10:17 ` Philippe Mathieu-Daudé
@ 2018-12-20 11:50 ` Roman Bolshakov
2019-01-08 14:53 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Roman Bolshakov @ 2018-12-20 11:50 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, peter.maydell
On Thu, Dec 20, 2018 at 09:45:59AM +0100, Markus Armbruster wrote:
> Avoids pointless recompilation. Missed in commit 112ed241f5d.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> ui/cocoa.m | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
Tested-by: Roman Bolshakov <r.bolshakov@yadro.com>
Thanks,
Roman
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v2] ui/cocoa: Include less of the generated modular QAPI headers
2018-12-20 8:45 [Qemu-devel] [PATCH v2] ui/cocoa: Include less of the generated modular QAPI headers Markus Armbruster
2018-12-20 10:17 ` Philippe Mathieu-Daudé
2018-12-20 11:50 ` Roman Bolshakov
@ 2019-01-08 14:53 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2019-01-08 14:53 UTC (permalink / raw)
To: Markus Armbruster; +Cc: QEMU Developers, Roman Bolshakov
On Thu, 20 Dec 2018 at 08:46, Markus Armbruster <armbru@redhat.com> wrote:
>
> Avoids pointless recompilation. Missed in commit 112ed241f5d.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> ui/cocoa.m | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index ecf12bfc2e..ddc058e76e 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -32,7 +32,8 @@
> #include "ui/input.h"
> #include "sysemu/sysemu.h"
> #include "qapi/error.h"
> -#include "qapi/qapi-commands.h"
> +#include "qapi/qapi-commands-block.h"
> +#include "qapi/qapi-commands-misc.h"
> #include "sysemu/blockdev.h"
> #include "qemu-version.h"
> #include <Carbon/Carbon.h>
> --
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-08 14:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-20 8:45 [Qemu-devel] [PATCH v2] ui/cocoa: Include less of the generated modular QAPI headers Markus Armbruster
2018-12-20 10:17 ` Philippe Mathieu-Daudé
2018-12-20 11:50 ` Roman Bolshakov
2019-01-08 14:53 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).