Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

[Peter Maydell <peter.maydell@linaro.org>]

On 24 November 2015 at 20:52, Andrew Jones <drjones@redhat.com> wrote:
>
> I've pulled a v2 together that I'll be testing and posting soon. Here's
> what I decided to do
>
> 1) Throw the fp registers in. Why not?
> 2) No linux-headers update, as we'd also need
>    include/uapi/linux/elfcore.h and arch/arm/include/asm/user.h.
>    However I've added comments stating where the structs come from.
> 3) Base the vmcore type on the guest kernel, i.e. use arm_el_is_aa64()
>    and (env->cp15.sctlr_el[1] & SCTLR_EE). However,
>    aarch64_write_elf64_note() will shoehorn 32-bit state into 64-bit
>    elf notes when the current state is 32-bit. Those analyzing the
>    dumps will need to look at the captured pstate to determine the
>    endianness of the registers.

Not sure what you have in mind by "endianness of the registers" --
typically registers aren't thought of as having endianness.

Also, if we're currently executing a 32-bit guest when we take
the core dump, you probably need to call aarch64_sync_32_to_64()
somewhere.

thanks
-- PMM